On Wed, Apr 18, 2012 at 8:49 PM, Tom Hacohen <tom.haco...@samsung.com> wrote: > On 18/04/12 14:44, Gustavo Sverzut Barbieri wrote: >> You are forcing it to a fixed File descriptor. Also you're imposing the >> getenv() in every log function. Make it a global state that can be enabled >> based on a numerical level. I'd also introduce a new backtrace function >> that can be provided by user, or just a generic "post log" user function >> that can contain a backtrace one, so maybe we can use it better. > > getenv should probably be cached, yeah.
Yep, done. > numerical level: good idea. Yep, done. > file descriptor: should be the same as the eina log prints. Yep, that's also my point of view. > backtrace function: no comment. Having a log post callback could be interesting, but I am wondering what else use it could have than current eina_log don't have. Do you have any use case in mind ? -- Cedric BAIL ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
