On Thu, 22 Mar 2012 18:44:40 +0900 Kim Shinwoo <kimcinoo....@gmail.com> said:
in svn! :) > AH!! sorry for this. now the patch follows.. > > - 1 space before parenthesis for keywords: if, for, while, switch > > Thanks for your response > > > 2012/3/22 Carsten Haitzler <ras...@rasterman.com>: > > On Thu, 22 Mar 2012 17:41:49 +0900 Kim Shinwoo <kimcinoo....@gmail.com> > > said: > > > > i STILL see a if() (vs if ().. notice the SPACE) :) > > > >> OMG. > >> I checked and revised whole elc_ctxpopup.c file to follow the coding > >> style as bellows. > >> > >> Add parenthesis around all conditions: > >> > >> if (a) ... > >> if (!a) ... > >> if ((a) && (b))... > >> if ((!a) && (b))... > >> > >> Please review the attached patch. Thanks! > >> > >> > >> 2012/3/22 Carsten Haitzler <ras...@rasterman.com>: > >> > On Thu, 22 Mar 2012 16:40:39 +0900 Kim Shinwoo <kimcinoo....@gmail.com> > >> > said: > >> > > >> > looks like its the exact same patch as before :) > >> > > >> >> Thank you for your response. > >> >> I have attached revised patch. > >> >> Please review this again, Thanks :) > >> >> > >> >> 2012/3/22 Carsten Haitzler <ras...@rasterman.com>: > >> >> > On Wed, 21 Mar 2012 18:19:26 +0900 cnook <kimci...@gmail.com> said: > >> >> > > >> >> >> Dear All, Hello. > >> >> >> > >> >> >> The patch is for using elm_list as a item controller of elc_ctxpopup. > >> >> >> I have learned that there was an opinion to change the internal > >> >> >> structure of ctxpopup using the list. > >> >> >> It would be able to match up to your expectation. but it is just a > >> >> >> draft version of using list in ctxpopup. > >> >> >> So, It would be pretty good to me if you give any feedback on this. > >> >> >> Thanks. > >> >> >> > >> >> >> Sincerely, > >> >> >> Shinwoo Kim. > >> >> > > >> >> > change: > >> >> > (wd->list && !wd->list_visible) > >> >> > to > >> >> > ((wd->list) && (!wd->list_visible)) > >> >> > > >> >> > change: > >> >> > if(list_size.x >= rect.w || list_size.y >= rect.h) > >> >> > to > >> >> > if ((list_size.x >= rect.w) || (list_size.y >= rect.h)) > >> >> > > >> >> > -- > >> >> > ------------- Codito, ergo sum - "I code, therefore I am" > >> >> > -------------- The Rasterman (Carsten Haitzler) > >> >> > ras...@rasterman.com > >> >> > > >> >> > > >> >> > ------------------------------------------------------------------------------ > >> >> > This SF email is sponsosred by: > >> >> > Try Windows Azure free for 90 days Click Here > >> >> > http://p.sf.net/sfu/sfd2d-msazure > >> >> > _______________________________________________ > >> >> > enlightenment-devel mailing list > >> >> > enlightenment-devel@lists.sourceforge.net > >> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > >> > > >> > -- > >> > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > >> > The Rasterman (Carsten Haitzler) ras...@rasterman.com > >> > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
