On Sun, 25 Mar 2012 15:45:21 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
> Question in _item_content_realize(). > > I don't see a point to merge the list here. > > + *source = eina_list_merge(*source, cons); > > *source must be NULL when you run _item_content_realize(). > If it's not NULL, that's a huge problem. > Creating another list pointer(cons) and merging it with NULL is > unnecessary extra job. > We do not need to merge source(which is NULL) and cons here. Just use source. > > Daniel Juyung Seo (SeoZ) ti looks cleaner though imho. :) > On Sat, Mar 24, 2012 at 8:15 PM, Carsten Haitzler <ras...@rasterman.com> > wrote: > > On Fri, 23 Mar 2012 19:19:55 +0900 Hyoyoung Chang <hyoyo...@gmail.com> said: > > > > tnx! looked at it - in svn! :) > > > >> Dear all > >> > >> I add like a routine in previous patch. > >> It add merging routines to realize functions. > >> also i removed "elm_widget_stringlist_free(cons)" > >> because all of it is freed at item_unrealize. > >> > >> Thanks > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > ------------------------------------------------------------------------------ > > This SF email is sponsosred by: > > Try Windows Azure free for 90 days Click Here > > http://p.sf.net/sfu/sfd2d-msazure > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
