in most of cases, Daniel is right.
But i added this for item_fields_update
if ((!itf) || (itf & ELM_GENLIST_ITEM_FIELD_CONTENT))
{
_it->content_objs = _item_content_unrealize(_it, VIEW(_it),
&_it->contents, parts);
_it->content_objs = _item_content_realize(_it, VIEW(_it),
&_it->contents, parts);
}
as you know, in the field_update, individual items can be updated.
Also, i think it can be used at merging item_content_realize with
item_flip_realize in future.
On Sun, Mar 25, 2012 at 3:57 PM, Carsten Haitzler <[email protected]> wrote:
> On Sun, 25 Mar 2012 15:45:21 +0900 Daniel Juyung Seo <[email protected]>
> said:
>
>> Question in _item_content_realize().
>>
>> I don't see a point to merge the list here.
>> > + *source = eina_list_merge(*source, cons);
>>
>> *source must be NULL when you run _item_content_realize().
>> If it's not NULL, that's a huge problem.
>> Creating another list pointer(cons) and merging it with NULL is
>> unnecessary extra job.
>> We do not need to merge source(which is NULL) and cons here. Just use source.
>>
>> Daniel Juyung Seo (SeoZ)
>
> ti looks cleaner though imho. :)
>
>> On Sat, Mar 24, 2012 at 8:15 PM, Carsten Haitzler <[email protected]>
>> wrote:
>> > On Fri, 23 Mar 2012 19:19:55 +0900 Hyoyoung Chang <[email protected]>
>> > said:
>> >
>> > tnx! looked at it - in svn! :)
>> >
>> >> Dear all
>> >>
>> >> I add like a routine in previous patch.
>> >> It add merging routines to realize functions.
>> >> also i removed "elm_widget_stringlist_free(cons)"
>> >> because all of it is freed at item_unrealize.
>> >>
>> >> Thanks
>> >
>> >
>> > --
>> > ------------- Codito, ergo sum - "I code, therefore I am" --------------
>> > The Rasterman (Carsten Haitzler) [email protected]
>> >
>> >
>> > ------------------------------------------------------------------------------
>> > This SF email is sponsosred by:
>> > Try Windows Azure free for 90 days Click Here
>> > http://p.sf.net/sfu/sfd2d-msazure
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>> ------------------------------------------------------------------------------
>> This SF email is sponsosred by:
>> Try Windows Azure free for 90 days Click Here
>> http://p.sf.net/sfu/sfd2d-msazure
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler) [email protected]
>
>
> ------------------------------------------------------------------------------
> This SF email is sponsosred by:
> Try Windows Azure free for 90 days Click Here
> http://p.sf.net/sfu/sfd2d-msazure
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
