On Fri, Mar 30, 2012 at 1:32 PM, Vincent Torri <vincent.to...@gmail.com> wrote: > On Fri, Mar 30, 2012 at 6:27 PM, Lucas De Marchi > <lucas.demar...@profusion.mobi> wrote: >> On Fri, Mar 30, 2012 at 11:41 AM, Vincent Torri <vincent.to...@gmail.com> >> wrote: >>> On Fri, Mar 30, 2012 at 4:32 PM, Lucas De Marchi >>> <lucas.demar...@profusion.mobi> wrote: >>>> On Fri, Mar 30, 2012 at 11:03 AM, Vincent Torri <vincent.to...@gmail.com> >>>> wrote: >>>>> On Fri, Mar 30, 2012 at 3:40 PM, Gustavo Sverzut Barbieri >>>>> <barbi...@profusion.mobi> wrote: >>>>>> On Thu, Mar 29, 2012 at 5:55 PM, Enlightenment SVN >>>>>> <no-re...@enlightenment.org> wrote: >>>>>>> Log: >>>>>>> Remove warnings about unused parameters in examples. >>>>>>> >>>>>>> Author: gastal >>>>>>> Date: 2012-03-29 13:55:55 -0700 (Thu, 29 Mar 2012) >>>>>>> New Revision: 69769 >>>>>>> Trac: http://trac.enlightenment.org/e/changeset/69769 >>>>>>> >>>>>>> Modified: >>>>>>> trunk/elementary/src/examples/Makefile.am >>>>>>> >>>>>>> Modified: trunk/elementary/src/examples/Makefile.am >>>>>>> =================================================================== >>>>>>> --- trunk/elementary/src/examples/Makefile.am 2012-03-29 20:51:52 UTC >>>>>>> (rev 69768) >>>>>>> +++ trunk/elementary/src/examples/Makefile.am 2012-03-29 20:55:55 UTC >>>>>>> (rev 69769) >>>>>>> @@ -7,6 +7,7 @@ >>>>>>> files_DATA = >>>>>>> >>>>>>> AM_CPPFLAGS = \ >>>>>>> +-Wno-unused-parameter \ >>>>>> >>>>>> I'll wait for Vincent take on this, but for sure it will break with >>>>>> non-gcc... but do we support non-gcc? >>>>>> >>>>>> The correct solution is a bit of a PITA, you need to save flags in >>>>>> configure.ac, test if compiler supports, then save the flag in a >>>>>> special variable you ask for replacement >>>>>> (@NO_UNUSED_PARAMETER_CFLAGS@) at Makefile.am... :-/ >>>>> >>>>> i've written a macro that checks if a compiler flag is supported, and >>>>> ad it to CFLAGS. Loook in eina/m4/common >>>> >>>> btw after investigating this for kmod, I noticed this is the wrong >>>> thing to do (see this reference: >>>> http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html). >>>> >>>> I've created another macro that plays well with _user_ flags like >>>> CFLAGS/LDFLAGS: >>>> http://git.kernel.org/?p=utils/kernel/kmod/kmod.git;a=blobdiff;f=m4/attributes.m4;h=c80ae62ede635d3b1fccc22fd69f30c9f7f04250;hp=20d05e4bde8869db5022da1b1bebe9480dd03dbb;hb=e48f37657dc03aee9aace60bf14ef9af489bf47c;hpb=3ef7208ecfa2fb3edc0d3f6344811e686907c94c >>>> >>>> It's already applied in kmod and systemd. >>>> >>>> Vincent, would you be interested that I port it to EFL? Any objections? >>> >>> in that case, I don't think that the order is important. Right ? >> >> I was talking about this: >> >> "You should never redefine a user variable such as CPPFLAGS in >> Makefile.am. Use ‘automake -Woverride’ to diagnose such mistakes. Even >> something like" >> >> ... >> >> "You should not add options to these user variables within configure >> either, for the same reason. Occasionally you need to modify these >> variables to perform a test, but you should reset their values >> afterwards. In contrast, it is OK to modify the ‘AM_’ variables within >> configure if you AC_SUBST them, but it is rather rare that you need to >> do this, unless you really want to change the default definitions of >> the ‘AM_’ variables in all Makefiles." > > Ha, in that case, it requires a bit more work. > > I'll plan to do something even more clean that what is done when we'll > merge the EFL in a single tree.
You may look in kmod/systemd... it's already there. Feel free to copy/paste/modify for EFL. Lucas De Marchi ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
