I promise this one is not about FreeBSD. It looks like there isn't much consistency in the order of the boilerplate argument checks in Eina: some functions perform a magic check before using EINA_SAFETY_ON_NULL_RETURN or something similar, while others do the opposite (it also happens that some functions in a given module such as Eina_Hash sometimes perform a magic check first and other functions bail out on NULL first).
Personally, I think the latter makes more sense (if you pass NULL you just perform a NOP), but even if the consensus is that doing magic checks first is correct the documentation and the code should be updated to make things consistent. Thoughts? ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
