On Sun, Nov 25, 2012 at 9:57 PM, Gustavo Sverzut Barbieri
<[email protected]> wrote:
> On Sunday, November 25, 2012, Tom Hacohen wrote:
>
>> Not when you have 30 wifis in the same area. This makes things just
>> impossible. If there's a bug in connman/the module, it should be fixed, but
>> usability ATM is just crap.
>
>
>
> It's in wpa_supplicant that scans, emits a signal and connman sends another
> and we show it
It's right, but... it's possible to handle that in our module, setting
a timer while the popup is open. Something like:
popup_open_cb()
...
module_data->allow_list_update = EINA_FALSE
ecore_timer_add(config_time, _allow_update, module_data)
_allow_update(module_data)
module->allow_list_update = EINA_TRUE
return EINA_FALSE
_connman_update_cb(module_data)
if (!module_data->allow_list_update)
return /* bad */
update_popup_list(module_data)
module_data->allow_list_update = EINA_FALSE
ecore_timer_add(config_time, _allow_update, module_data)
The line tagged as bad is bad because if I remember correctly, connman
will just send us a signal after something changes (network is removed
/ added / list sorted),
so we can be discarding a change that happened between a config_time
frametime and the outdate information will
persist in our list for a long time.
So maybe a better would be:
popup_open_cb()
...
module_data->allow_list_update = EINA_FALSE
module_data->popup_list_outdated = EINA_FALSE
ecore_timer_add(config_time, _allow_update, module_data)
_allow_update(module_data)
if (module_data->popup_list_outdated)
update_popup_list(module_data)
module_data->popup_list_outdated = EINA_FALSE
return EINA_TRUE
module->allow_list_update = EINA_TRUE
return EINA_FALSE
_connman_update_cb(module_data)
update_module_data_list(module_data) /* update internal list, not
the popup list*/
if (!module_data->allow_list_update)
module_data->popup_list_outdated = EINA_TRUE
return
update_popup_list(module_data)
module_data->allow_list_update = EINA_FALSE
ecore_timer_add(config_time, _allow_update, module_data)
And we would need to make sure everything would work fine with this lists
out of sync. Also timer should be properly deleted when popup is closed, etc.
But I definitely don't like the proposal of not updating the list
while the popup is open.
Regards
>
>
>
>>
>> --
>> Tom.
>> On 25 Nov 2012 14:22, "Luis Felipe Strano Moraes"
>> <[email protected]<javascript:;>
>> >
>> wrote:
>>
>> > On Sun, Nov 25, 2012 at 12:15 PM, Tom Hacohen
>> > <[email protected]<javascript:;>>
>> wrote:
>> >
>> > > Hey,
>> > >
>> > > I want to change the connman module to only refresh the list when the
>> > menu
>> > > is popped, and not every X seconds like it does now. It's terribly
>> > annoying
>> > > when there are plenty of wifis available as the list changes while I'm
>> > > trying to fins a network. Any objections or should I just do it?
>> > >
>> >
>> > Aren't users somewhat used to that happening? Not sure why, but not all
>> > wifis appear on the scan in a reliable way every time so usually you
>> open
>> > the list and wait a few seconds until the one you want shows up.
>> >
>> > --lf
>> >
>> >
>> >
>> > >
>> > > --
>> > > Tom.
>> > >
>> > >
>> >
>> ------------------------------------------------------------------------------
>> > > Monitor your physical, virtual and cloud infrastructure from a single
>> > > web console. Get in-depth insight into apps, servers, databases,
>> vmware,
>> > > SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> > > Pricing starts from $795 for 25 servers or applications!
>> > > http://p.sf.net/sfu/zoho_dev2dev_nov
>> > > _______________________________________________
>> > > enlightenment-devel mailing list
>> > > [email protected] <javascript:;>
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >
>> >
>> >
>> >
>> > --
>> > Luís Felipe Strano Moraes
>> > http://www.strano.org
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Monitor your physical, virtual and cloud infrastructure from a single
>> > web console. Get in-depth insight into apps, servers, databases, vmware,
>> > SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> > Pricing starts from $795 for 25 servers or applications!
>> > http://p.sf.net/sfu/zoho_dev2dev_nov
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > [email protected] <javascript:;>
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>>
>> ------------------------------------------------------------------------------
>> Monitor your physical, virtual and cloud infrastructure from a single
>> web console. Get in-depth insight into apps, servers, databases, vmware,
>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> Pricing starts from $795 for 25 servers or applications!
>> http://p.sf.net/sfu/zoho_dev2dev_nov
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected] <javascript:;>
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --------------------------------------
> MSN: [email protected]
> Skype: gsbarbieri
> Mobile: +55 (19) 9225-2202
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Bruno Dilly
Lead Developer
ProFUSION embedded systems
http://profusion.mobi
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
