On Mon, 26 Nov 2012 12:16:01 -0200 Lucas De Marchi <[email protected]> wrote:
> On Mon, Nov 26, 2012 at 12:08 AM, Bruno Dilly <[email protected]> > wrote: > > On Sun, Nov 25, 2012 at 9:57 PM, Gustavo Sverzut Barbieri > > <[email protected]> wrote: > >> On Sunday, November 25, 2012, Tom Hacohen wrote: > >> > >>> Not when you have 30 wifis in the same area. This makes things > >>> just impossible. If there's a bug in connman/the module, it > >>> should be fixed, but usability ATM is just crap. > >> > >> > >> > >> It's in wpa_supplicant that scans, emits a signal and connman > >> sends another and we show it > > > > It's right, but... it's possible to handle that in our module, > > setting a timer while the popup is open. Something like: > > > > popup_open_cb() > > ... > > module_data->allow_list_update = EINA_FALSE > > ecore_timer_add(config_time, _allow_update, module_data) > > > > > > _allow_update(module_data) > > module->allow_list_update = EINA_TRUE > > return EINA_FALSE > > > > > > _connman_update_cb(module_data) > > if (!module_data->allow_list_update) > > return /* bad */ > > update_popup_list(module_data) > > module_data->allow_list_update = EINA_FALSE > > ecore_timer_add(config_time, _allow_update, module_data) > > > > > > The line tagged as bad is bad because if I remember correctly, > > connman will just send us a signal after something changes (network > > is removed / added / list sorted), > > so we can be discarding a change that happened between a config_time > > frametime and the outdate information will > > persist in our list for a long time. > > No.... don't do this. We could maintain the popup list not > synchronized with connman's list. However discarding updates to the > *connman* list will open cans of worms. > > So, if we are going to implement this delay, it should be only in the > update_popup_list() function, not in econnman.c. > > > > > So maybe a better would be: > > popup_open_cb() > > ... > > module_data->allow_list_update = EINA_FALSE > > module_data->popup_list_outdated = EINA_FALSE > > ecore_timer_add(config_time, _allow_update, module_data) > > > > > > _allow_update(module_data) > > if (module_data->popup_list_outdated) > > update_popup_list(module_data) > > module_data->popup_list_outdated = EINA_FALSE > > return EINA_TRUE > > module->allow_list_update = EINA_TRUE > > return EINA_FALSE > > > > > > _connman_update_cb(module_data) > > update_module_data_list(module_data) /* update internal list, not > > the popup list*/ > > if (!module_data->allow_list_update) > > module_data->popup_list_outdated = EINA_TRUE > > return > > update_popup_list(module_data) > > module_data->allow_list_update = EINA_FALSE > > ecore_timer_add(config_time, _allow_update, module_data) > > > > > > And we would need to make sure everything would work fine with this > > lists out of sync. Also timer should be properly deleted when popup > > is closed, etc. > > > > But I definitely don't like the proposal of not updating the list > > while the popup is open. > > I don't either. However if you have 30+ services, you'll have a hard > time finding the service you want because: > > 1) If signal strengths change in such a way that services are > reordered, the popup list will be deleted and recreated > 2) If networks are added/removed, the popup list will be deleted and > recreated. > > And this (I think) implies that the list will scroll back to the > initial position. It's not a problem for simpler cases, but it really > is when you are in a public place with lots of wifi APs. > > So, IMO what needs to be done is to either delay updates *to popup > list* when popup is open. Or even doesn't allow it at all. However the > second approach seems bad for my daily use of opening the popup and > waiting for the service to show up. With 30 WiFi hot spots they are gonna be fighting each other over the channels used. Might be better to show the list A) sorted by name, and B) collected and updated over a lengthy period. That way the one out of the 30 you are looking for has a chance to actually stay in a predictable spot for long enough for you to hit it. Even if it fades out every few seconds due to hot spot congestion, it should stay in the list for some time. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
