On Fri, Dec 14, 2012 at 7:42 AM, Carsten Haitzler <[email protected]>wrote:
> On Fri, 14 Dec 2012 07:15:04 +0000 Michael Blumenkrantz > <[email protected]> said: > > > On Fri, 14 Dec 2012 14:49:07 +0900 > > Carsten Haitzler (The Rasterman) <[email protected]> wrote: > > > > > On Thu, 13 Dec 2012 12:39:22 +0000 Michael Blumenkrantz > > > <[email protected]> said: > > > > > > i suggest you then revert 80747, 80774, and 80890 which are all feature > > > adds. 80654 is a code cleanup and no fix - so under the same strict > rules - > > > revert. > > > > big difference between adding an actual feature like this one and > > copy/pasting a couple lines of code around to add an event which is not > used > > internally and thus cannot cause bugs by default. if you were going to > make > > this argument, you should have tested it adequately such that the themes > in > > SVN at least look decent with it. > > i did. and darkness failed. it failed because i hadn't put in the fallback > to > default code yet and it didn't provide comp stuff. i ran out of time to > finish > it that day and i had to be in the office early for a conf call so i had to > leave it be. i tested with darkness, detorious, detorious dark and efnheit > and > default. i finished it up first thing in the morning. see my commit. > great > > nb - it CAN cause bugs. you generate an event.. do you free it? do you > free all > members? do you unreff reffed objects on event free? sure that event doesnt > post any event struct/data... but these are not always innocuous things. > you > if an event with no data is causing a problem, we have some serious ecore bugs to fix. > just added a 100% cpu spin bug into e17 in 80871 that wasn't fixing any > actual > bug... you should have tested adequately to avoid making e17 using 100% > cpu all > day. > out of an entire day spent reviewing over 150 trivial issues reported by a static analyzer,, ONE resulting commit caused an issue. thanks for pointing that out, I look forward to the day when I never make a bad commit. > > at least my incomplete code simply was cosmetic issues that are all happy > now. > > > > > > > also - no improvements to randr dialog then from devilhorns. you can > stop > > > work now as no features are allowed. > > > > > > seriously... you violate this yourself repeatedly... and you plan on > > > reverting the randr code devilhorns has been hoarding until now and is > > > meant to go into svn? it ADDS cloning controls... for example. > > > > you assume that this will be done in time for release I guess. he's only > got > > i assume because he cancelled his holiday today just so he could do it for > you. > > > a couple more days to work on it since he'll be on vacation, and, while I > > have high hopes and trust in his ability, his current outlook is not > nearly > > as optimistic. > > > > regardless, this would be a bug fix since the current dialog barely > works, > > and we've previously discussed that it needed to go in. > > and we've previously discussed the theme preview as one of the reasons to > have > a thumbnailer custom inside e17. > > how about i file a bug "cannot determine look of theme from just a > wallpaper, so if theme makes all buttons black, with black text and i apply > the theme, i cannot un-apply it"? that's a bug. a fuller preview solves it. > consider this a bug fix. > > > > > > > :) > > > > at this point I give up. we may as well go on and throw the edbus2 > changes in > > now > > no one said that. what i'm saying is that if dh puts his changes in today - > u'll be all happy with major untested code (he's had it for days and weeks > without sharing - thus a lot of work with little feedback on it). that's a > lot of new features. > > my changes fix a usability bug and improve look. they show the color of > buttons > and dialogs so you can see your controls are about to be blacked out.. or > not. > > > > > > > > being awesome is great, but we're 1 week away from final release and > have > > > > been in a feature freeze since last friday when we hit beta. please > revert > > > > this until after the release. > > > > > > > > On Thu, Dec 13, 2012 at 12:27 PM, Enlightenment SVN < > > > > [email protected]> wrote: > > > > > > > > > Log: > > > > > lets be awesome ... and make the theme preview.. look a lot more > like > > > > > a REAL PREVIEW OF A THEME! > > > > > > > > > > > > > > > > > > > > Author: raster > > > > > Date: 2012-12-13 04:27:03 -0800 (Thu, 13 Dec 2012) > > > > > New Revision: 80834 > > > > > Trac: http://trac.enlightenment.org/e/changeset/80834 > > > > > > > > > > Modified: > > > > > trunk/e/src/modules/conf_theme/e_int_config_theme.c > > > > > ------------------------------------------------------------------------------ > > > > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > > > > Remotely access PCs and mobile devices and provide instant support > > > > Improve your efficiency, and focus on delivering more value-add > services > > > > Discover what IT Professionals Know. Rescue delivers > > > > http://p.sf.net/sfu/logmein_12329d2d > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > [email protected] > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > > Remotely access PCs and mobile devices and provide instant support > > Improve your efficiency, and focus on delivering more value-add services > > Discover what IT Professionals Know. Rescue delivers > > http://p.sf.net/sfu/logmein_12329d2d > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > like I said, I'm done arguing about release stuff. keep going and ignore this thread. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
