And now for my more serious reply ... On Fri, 14 Dec 2012 08:47:04 +0000 Michael Blumenkrantz <[email protected]> wrote:
> On Fri, Dec 14, 2012 at 7:42 AM, Carsten Haitzler > <[email protected]>wrote: > > > On Fri, 14 Dec 2012 07:15:04 +0000 Michael Blumenkrantz > > <[email protected]> said: > > > > > On Fri, 14 Dec 2012 14:49:07 +0900 > > > Carsten Haitzler (The Rasterman) <[email protected]> wrote: > > > > > > > On Thu, 13 Dec 2012 12:39:22 +0000 Michael Blumenkrantz > > > > <[email protected]> said: > > > > > > > > i suggest you then revert 80747, 80774, and 80890 which are all > > > > feature adds. 80654 is a code cleanup and no fix - so under the > > > > same strict > > rules - > > > > revert. > > > > > > big difference between adding an actual feature like this one and > > > copy/pasting a couple lines of code around to add an event which > > > is not > > used > > > internally and thus cannot cause bugs by default. if you were > > > going to > > make > > > this argument, you should have tested it adequately such that the > > > themes > > in > > > SVN at least look decent with it. > > > > i did. and darkness failed. it failed because i hadn't put in the > > fallback to > > default code yet and it didn't provide comp stuff. i ran out of > > time to finish > > it that day and i had to be in the office early for a conf call so > > i had to leave it be. i tested with darkness, detorious, detorious > > dark and efnheit and > > default. i finished it up first thing in the morning. see my commit. > > > > great > > > > > > nb - it CAN cause bugs. you generate an event.. do you free it? do > > you free all > > members? do you unreff reffed objects on event free? sure that > > event doesnt post any event struct/data... but these are not always > > innocuous things. you > > > > if an event with no data is causing a problem, we have some serious > ecore bugs to fix. > > > > just added a 100% cpu spin bug into e17 in 80871 that wasn't fixing > > any actual > > bug... you should have tested adequately to avoid making e17 using > > 100% cpu all > > day. > > > > out of an entire day spent reviewing over 150 trivial issues reported > by a static analyzer,, You have been doing a great job to get E17 ready for release. I'm sure we all appreciate all the work you have been doing polishing up the code and sorting out the problems. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world.
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
