On Fri, 28 Dec 2012 18:52:49 -0800
"Enlightenment SVN" <no-re...@enlightenment.org> wrote:

> Log:
> ummm the problem must be elsehwere... as not calling the prent del
>   means we leak smart members and clipper objects on termio smart
>   shutdown. that'll be fun with > 1 term in a window. :( could you bring
>   up a valgrind trace etc. about this?
>   
>   
> 
> Author:       raster
> Date:         2012-12-28 18:52:48 -0800 (Fri, 28 Dec 2012)
> New Revision: 81853
> Trac:         http://trac.enlightenment.org/e/changeset/81853
> 
> Modified:
>   trunk/terminology/src/bin/termio.c 
> 
> Modified: trunk/terminology/src/bin/termio.c
> ===================================================================
> --- trunk/terminology/src/bin/termio.c        2012-12-29 02:46:39 UTC (rev 
> 81852)
> +++ trunk/terminology/src/bin/termio.c        2012-12-29 02:52:48 UTC (rev 
> 81853)
> @@ -2346,7 +2346,7 @@
>  
>     termpty_shutdown();
>  
> -   //_parent_sc.del(obj);
> +   _parent_sc.del(obj);
>     evas_object_smart_data_set(obj, NULL);
>     free(sd);
>  }
> 
> 

on my machine it crashes every time I close a terminal without this change.

==26168== Invalid free() / delete / delete[] / realloc()
==26168==    at 0x4C2B35C: free (vg_replace_malloc.c:446)
==26168==    by 0x41D7BF: _smart_del (termio.c:2351)
==26168==    by 0x6651080: evas_object_smart_del (evas_object_smart.c:899)
==26168==    by 0x6644635: evas_object_del (evas_object_main.c:470)
==26168==    by 0x40D4C9: main_term_free (main.c:638)
==26168==    by 0x40C071: _cb_exited (main.c:162)
==26168==    by 0x66502A4: evas_object_smart_callback_call 
(evas_object_smart.c:610)
==26168==    by 0x41DD4A: _smart_pty_exited (termio.c:2494)
==26168==    by 0x42031F: _cb_exe_exit (termpty.c:166)
==26168==    by 0x6B9A068: _ecore_call_handler_cb (ecore_private.h:321)
==26168==    by 0x6B9B052: _ecore_event_call (ecore_events.c:559)
==26168==    by 0x6BA2569: _ecore_main_loop_iterate_internal (ecore_main.c:1922)
==26168==    by 0x6BA0899: ecore_main_loop_begin (ecore_main.c:956)
==26168==    by 0x4F23DC9: elm_run (elm_main.c:849)
==26168==    by 0x40EE6F: elm_main (main.c:1304)
==26168==    by 0x40EF39: main (main.c:1326)
==26168==  Address 0xfdeee40 is 0 bytes inside a block of size 304 free'd
==26168==    at 0x4C2B35C: free (vg_replace_malloc.c:446)
==26168==    by 0x6651E65: evas_object_smart_clipped_smart_del 
(evas_object_smart_clipped.c:81)
==26168==    by 0x41D7A2: _smart_del (termio.c:2349)
==26168==    by 0x6651080: evas_object_smart_del (evas_object_smart.c:899)
==26168==    by 0x6644635: evas_object_del (evas_object_main.c:470)
==26168==    by 0x40D4C9: main_term_free (main.c:638)
==26168==    by 0x40C071: _cb_exited (main.c:162)
==26168==    by 0x66502A4: evas_object_smart_callback_call 
(evas_object_smart.c:610)
==26168==    by 0x41DD4A: _smart_pty_exited (termio.c:2494)
==26168==    by 0x42031F: _cb_exe_exit (termpty.c:166)
==26168==    by 0x6B9A068: _ecore_call_handler_cb (ecore_private.h:321)
==26168==    by 0x6B9B052: _ecore_event_call (ecore_events.c:559)
==26168==    by 0x6BA2569: _ecore_main_loop_iterate_internal (ecore_main.c:1922)
==26168==    by 0x6BA0899: ecore_main_loop_begin (ecore_main.c:956)
==26168==    by 0x4F23DC9: elm_run (elm_main.c:849)
==26168==    by 0x40EE6F: elm_main (main.c:1304)
==26168==    by 0x40EF39: main (main.c:1326)

also I get this on startup:

==26168== Invalid read of size 8
==26168==    at 0x9CE3B81: FT_Load_Glyph (ftobjs.c:612)
==26168==    by 0x66CC5B5: evas_common_font_int_cache_glyph_get 
(evas_font_main.c:410)
==26168==    by 0x66E698F: _content_create_regular (evas_text_utils.c:458)
==26168==    by 0x66E6C8D: evas_common_text_props_content_create 
(evas_text_utils.c:544)
==26168==    by 0x6718F57: eng_font_text_props_info_create (evas_engine.c:1252)
==26168==    by 0x667F526: evas_object_textgrid_font_set 
(evas_object_textgrid.c:1139)
==26168==    by 0x41C721: _termio_config_set (termio.c:2028)
==26168==    by 0x41DF0E: termio_add (termio.c:2533)
==26168==    by 0x40D806: main_term_new (main.c:694)
==26168==    by 0x40ED1D: elm_main (main.c:1277)
==26168==    by 0x40EF39: main (main.c:1326)
==26168==  Address 0xfe00ea0 is not stack'd, malloc'd or (recently) free'd


using 1.7 branch, no edbus crashes :D

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to