Hello, On Tue, Jan 1, 2013 at 1:00 AM, Ulisses Furquim <ulis...@profusion.mobi> wrote: > On Sun, Dec 30, 2012 at 9:50 PM, Cedric BAIL <cedric.b...@free.fr> wrote: >> I am disappointed by your answer. Terminology now use 4 times more CPU >> and your answer is just live with it ! You didn't even look at it. So >> I took the time to see what was going on, basically we are allocating >> memory like crazy and waking up the main loop to often. I fixed the >> main loop wake up issue and I also partially fixed the memory >> allocation issue. > > Cedric, really, we were focused on making it actually working first. > Thanks for taking a look at it and for fixing the problems. I did tell > Gustavo we were allocating/deallocating too much memory and we'd have > to fix that. As for waking up the main loop too often, that's because > we are notifying the main thread _unref() the objects, clearly.
Indeed. I have done some more investigation on why it impact all this test case. Basically the Evas_Thread_Command_* are to big for data that don't change that often. It could be good to divide them more. Like having a Evas_Thread_Command_Image_Context that will update mul_col, render_op and smooth or in font something that will keep gl_* and all the almost never changing value. I think you get the idea. We need to allocate less often, but also allocate less. I did have some 4MB spike of just Evas_Thread_Command_Font in terminology for example. Terminology is pathological here as it has one text_prop per character, but I guess we do have the same kind of problem with all text rendering as all test with text are slower. >> But there is still a problem there, it seems that we >> do rebuild the glyph array every time we render a text. That should >> definitively only happen when the text change. I also noticed that we >> do malloc and copy Evas_Map without using refcounting or anything like >> that. Could you look at both issue ? > > After the holidays I'll ask the team to take a look at both of these. Yeah, thanks a lot :-) -- Cedric BAIL ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
