On Mon, Jan 7, 2013 at 8:53 PM, Joel Klinghed <the...@spawned.biz> wrote:
> On Mon, 7 Jan 2013 20:39:26 -0200 > Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > > > Hi Joel, > > > > This looks fine, one last question: why are these needed? > > > > =================================================================== > > --- src/Makefile_Ecore_Evas.am (revision 82364) > > +++ src/Makefile_Ecore_Evas.am (working copy) > > @@ -74,7 +74,8 @@ > > -I$(top_srcdir)/src/lib/ecore_x \ > > -I$(top_builddir)/src/lib/ecore_x \ > > -I$(top_srcdir)/src/modules/evas/engines/software_x11 \ > > --I$(top_srcdir)/src/modules/evas/engines/gl_x11 > > +-I$(top_srcdir)/src/modules/evas/engines/gl_x11 \ > > +@ECORE_X_CFLAGS@ > > modules_ecore_evas_engines_x_module_la_LIBADD = \ > > lib/ecore_evas/libecore_evas.la \ > > lib/ecore_x/libecore_x.la > > Without this I get: > > In file included from modules/ecore_evas/engines/x/ecore_evas_x.c:22: > ../src/modules/evas/engines/gl_x11/Evas_Engine_GL_X11.h:4:10: fatal > error: 'X11/Xlib.h' file not found > > I assume this is the one you found. > ok, this was fixed today by raster. You can drop this from your patch :-) > Index: src/Makefile_Ecore_Imf.am > > =================================================================== > > --- src/Makefile_Ecore_Imf.am (revision 82364) > > +++ src/Makefile_Ecore_Imf.am (working copy) > > @@ -155,7 +155,8 @@ > > -I$(top_builddir)/src/lib/ecore_x \ > > -I$(top_srcdir)/src/lib/ecore_imf \ > > @ECORE_IMF_CFLAGS@ \ > > -@EFL_COV_CFLAGS@ > > +@EFL_COV_CFLAGS@ \ > > +@ECORE_X_CFLAGS@ > > modules_ecore_immodules_xim_xim_la_LIBADD = \ > > lib/ecore_imf/libecore_imf.la \ > > lib/ecore_x/libecore_x.la \ > > Without this I get: > modules/ecore/immodules/xim/ecore_imf_xim.c:10:10: fatal error: > 'X11/Xlib.h' file not found > this is really needed, but we shouldn't use ECORE_X_CFLAGS. Rather we need to find out XIM requirements and do another CFLAGS/LIBS pair. >From what it seems to be: #include <X11/Xlib.h> #include <X11/Xlocale.h> #include <X11/Xutil.h> The symbols seems to be all in libX11.so Would you do this? If I'm not asking enough, a last desire would be: could you please add support for Xlib .pc files? :-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
