committed as it will help you, but would be nice to simplify even further.
>From logs:
checking how to find X... use pkg-config
checking for EFL_X11... yes
checking X11/X.h usability... yes
checking X11/X.h presence... yes
checking for X11/X.h... yes
checking for evas_engine_software_xlib... yes
checking for XCreateImage... yes
checking for XShmCreateImage... yes
...
checking how to find X... (cached) already found
checking X11/Xlib.h usability... yes
checking X11/Xlib.h presence... yes
checking for X11/Xlib.h... yes
checking X11/Xatom.h usability... yes
checking X11/Xatom.h presence... yes
checking for X11/Xatom.h... yes
checking X11/Xutil.h usability... yes
checking X11/Xutil.h presence... yes
checking for X11/Xutil.h... yes
checking X11/extensions/Xrender.h usability... yes
checking X11/extensions/Xrender.h presence... yes
checking for X11/extensions/Xrender.h... yes
checking X11/Xresource.h usability... yes
checking X11/Xresource.h presence... yes
checking for X11/Xresource.h... yes
checking for evas_engine_gl_xlib... yes
checking for XCreateColormap... yes
checking for XRenderCreatePicture... yes
if using pkg-config, do not check any of header of symbols.
Situation with Ecore_X is also the same:
checking how to find X... (cached) already found
checking for X11/Xlib.h... (cached) yes
checking X11/Xcursor/Xcursor.h usability... yes
checking X11/Xcursor/Xcursor.h presence... yes
checking for X11/Xcursor/Xcursor.h... yes
checking for ECORE_X_XLIB... yes
checking for XOpenDisplay... yes
checking for XcursorImageLoadCursor... yes
checking for X11/extensions/XKB.h... yes
checking for XkbSetDetectableAutoRepeat in -lX11... yes
checking for X11/extensions/Xcomposite.h... yes
checking for XCompositeQueryExtension in -lXcomposite... yes
checking for X11/extensions/Xdamage.h... yes
checking for XDamageSubtract in -lXdamage... yes
checking for X11/extensions/dpms.h... yes
checking for DPMSQueryExtension in -lXext... yes
checking for X11/extensions/Xfixes.h... yes
checking for XFixesExpandRegion in -lXfixes... yes
checking for X11/extensions/Xinerama.h... yes
checking for XineramaQueryScreens in -lXinerama... yes
checking for X11/extensions/Print.h... yes
checking for XpQueryScreens in -lXp... yes
checking for X11/extensions/Xrandr.h... yes
checking for XRRGetScreenResourcesCurrent in -lXrandr... yes
checking for X11/extensions/Xrender.h... (cached) yes
checking for XRenderFindVisualFormat in -lXrender... yes
checking for X11/extensions/XTest.h... yes
checking for XTestFakeKeyEvent in -lXtst... yes
checking for X11/extensions/scrnsaver.h... yes
checking for XScreenSaverSelectInput in -lXss... yes
checking for X11/extensions/XInput2.h... yes
checking for XIQueryDevice in -lXi... yes
if we detect it's pkg-config capable, just do EFL_DEPEND_PKG() as we do for
xcb. Will cut us lots of calls to gcc to check these.
Could you do this? :-)
Thank you for you help!
On Tue, Jan 8, 2013 at 11:22 PM, Joel Klinghed <the...@spawned.biz> wrote:
> On Tue, 8 Jan 2013 16:49:52 -0200
> Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote:
>
> > On Mon, Jan 7, 2013 at 8:53 PM, Joel Klinghed <the...@spawned.biz>
> > wrote:
> >
> > > On Mon, 7 Jan 2013 20:39:26 -0200
> > > Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote:
> > >
> > > > Hi Joel,
> > > >
> > > > This looks fine, one last question: why are these needed?
> > > >
> > > > ===================================================================
> > > > --- src/Makefile_Ecore_Evas.am (revision 82364)
> > > > +++ src/Makefile_Ecore_Evas.am (working copy)
> > > > @@ -74,7 +74,8 @@
> > > > -I$(top_srcdir)/src/lib/ecore_x \
> > > > -I$(top_builddir)/src/lib/ecore_x \
> > > > -I$(top_srcdir)/src/modules/evas/engines/software_x11 \
> > > > --I$(top_srcdir)/src/modules/evas/engines/gl_x11
> > > > +-I$(top_srcdir)/src/modules/evas/engines/gl_x11 \
> > > > +@ECORE_X_CFLAGS@
> > > > modules_ecore_evas_engines_x_module_la_LIBADD = \
> > > > lib/ecore_evas/libecore_evas.la \
> > > > lib/ecore_x/libecore_x.la
> > >
> > > Without this I get:
> > >
> > > In file included from
> > > modules/ecore_evas/engines/x/ecore_evas_x.c:22:
> ../src/modules/evas/engines/gl_x11/Evas_Engine_GL_X11.h:4:10:
> > > fatal error: 'X11/Xlib.h' file not found
> > >
> > > I assume this is the one you found.
> > >
> >
> > ok, this was fixed today by raster. You can drop this from your
> > patch :-)
> >
> >
> > > Index: src/Makefile_Ecore_Imf.am
> > > > ===================================================================
> > > > --- src/Makefile_Ecore_Imf.am (revision 82364)
> > > > +++ src/Makefile_Ecore_Imf.am (working copy)
> > > > @@ -155,7 +155,8 @@
> > > > -I$(top_builddir)/src/lib/ecore_x \
> > > > -I$(top_srcdir)/src/lib/ecore_imf \
> > > > @ECORE_IMF_CFLAGS@ \
> > > > -@EFL_COV_CFLAGS@
> > > > +@EFL_COV_CFLAGS@ \
> > > > +@ECORE_X_CFLAGS@
> > > > modules_ecore_immodules_xim_xim_la_LIBADD = \
> > > > lib/ecore_imf/libecore_imf.la \
> > > > lib/ecore_x/libecore_x.la \
> > >
> > > Without this I get:
> > > modules/ecore/immodules/xim/ecore_imf_xim.c:10:10: fatal error:
> > > 'X11/Xlib.h' file not found
> > >
> >
> > this is really needed, but we shouldn't use ECORE_X_CFLAGS.
> >
> > Rather we need to find out XIM requirements and do another
> > CFLAGS/LIBS pair.
> >
> > >From what it seems to be:
> > #include <X11/Xlib.h>
> > #include <X11/Xlocale.h>
> > #include <X11/Xutil.h>
> >
> > The symbols seems to be all in libX11.so
> >
> > Would you do this?
> >
> > If I'm not asking enough, a last desire would be: could you please add
> > support for Xlib .pc files? :-)
> >
>
> Damn you for getting me to do this ;)
>
> Changelog from the last patch:
> * Removed ECORE_X_CFLAGS from evas_ecore_x
> * Split out ecore_imf_xim to do its own check
> * Fixed problem with xcb:s makekeys, no rule for
> $(top_builddir)/src/utils/ecore/makekeys$(EXEEXT) exists so make
> used an implicit rule (ignoring any cflags of course)
> * Fixed gl_x11 engine to build with either Xlib or XCB (xcb flags were
> missing)
> * Added EFL_FIND_X and replace any used of AC_PATH_X{,TRA}.
> First looks for Xorg pkg-config files then if those arn't found it
> falls back to old AC_PATH_X. Also generalized common header and lib
> checks.
> Could probably use some polishing (the AC_CACHE_VAL cruft especially)
> but this is what I have time for tonight.
>
> /Joel Klinghed
>
>
>
> ------------------------------------------------------------------------------
> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
> and much more. Keep your Java skills current with LearnJavaNow -
> 200+ hours of step-by-step video tutorials by Java experts.
> SALE $49.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122612
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
