* Sohyun Kim <sohyun.a...@gmail.com> [2013-01-17 14:48:08 +0900]: Hi, Sohyun.
I think you might have broken theme API. If you kept the C API, though, I happy to ignore the other borkage, because this widget's code really sucks big time, as of now. You have my blessing to replace it. > Hello, this is Sohyun Kim. > I need your advice for refactorying the elc_multibuttonentry widget. > > When we used it in the tizen project, we found several fatal problems, and > they were very complex to fix. > Because multibuttonentry had structural weakness, as I fixed bugs, it > increased the complexity. > > Multibuttonentry had several big issues. > * resizing from box pack/unpack was occured frequently > (all items were unpacked and re-packed whenever it had focus and lost > focus, widget edje was clicked, even though on box resizing callback) > * focus > - focus was frequently changed between items. (from multibuttonentry -> > entry -> button -> entry..) > - button item kept selected state and emited signal although > multibuttonentry didn't have focus. > - it handled input panel state manually, but the panel was not shown > sometimes when entry got focus. > > I think bug fixing based on the current code, it makes code more complex, > So I want to make the widget new, more simply. > > * make use-cases simple > - when multibuttonentry gets focus, entry gets focus always if it is > editable. After that, when button item is clicked, the button gets focus. > - button selected state is available when multibuttonentry has focus. > * only when items should be unpacking or packing, it will be occured. > * handling focus and input panel state will be dealt with object events. > (not manually) > > Actually, I've made the new multibuttonentry widget recently, and it is > verified with tizen project internally. > I should have made it after discussing with you guys, but we had urgent and > long lasted issues, so I did it. > I feel sorry for that, but I want to contribute it with you guys. > > I didn't change apis and signals at all and the changes cover all scenario. > After reviewing all new codes, changing the codes with old one is the best > and simplest way to contribute for me, > but if patches should be divided to multiple by functions, I will follow it. > > Please give me any advice. > Or if you have any opinions for the refactorying, please feel free to tell > me. > > Regards, Sohyun. > ------------------------------------------------------------------------------ > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current > with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > MVPs and experts. ON SALE this month only -- learn more at: > http://p.sf.net/sfu/learnmore_122712 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Lima Chaves Senior Developer @ ProFUSION Embedded Systems ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
