On Sun, Feb 24, 2013 at 1:30 AM, Carsten Haitzler <[email protected]> wrote: > On Sun, 24 Feb 2013 01:06:41 +0900 Daniel Juyung Seo <[email protected]> > said: > >> Good job! Nice summary of arcanist. >> >> 1. But is there any way to do(submit, review, commit) from the phab >> web interface? > > no. well ok u can copy & paste a diff (create diff) but then there is no > context no src tree its relative to) so its just a dumb "review the diff" > thing.
Ok. I expected something like that when we use "arc diff" because gerrit supports web interface for review and commit(submit). That's good to have but ok without it. > >> 2. So basically all of us including committers should use phab to >> commit something? > > no - this is for REVIEW. if you want others to review BEFORE you commit/push - > then see that doc. we can always review after the commit if we want with > audit... but chances are we'll rarely do that. > Ok I misunderstood the doc. So basically we can just push. >> 3. Anybody who has an access can add me as a reviewer automatically >> for elementary patch? > > if you have an account with phab, it seems anyone can add you as a reviewer - > yes. :) > I mean *automatically* add me as a reviewer for elementary patches. I guess there must be a configuration for each arcanist project. Daniel Juyung Seo (SeoZ) >> Thanks. >> >> Daniel Juyung Seo (SeoZ) >> >> On Sun, Feb 24, 2013 at 12:48 AM, Carsten Haitzler <[email protected]> >> wrote: >> > I've written up a nice wiki page on this after some experimentation: >> > >> > https://phab.enlightenment.org/w/arcanist/ >> > >> > Please use arc(anist) to submit patches, or we get no context. right now I >> > KNOW if you have commit access you can submit a patch and commit it. You >> > can even push it before approval, but arc complains. I currently don't know >> > what to do about patches submitted if you do not have commit access. I >> > don't know if arc land will work or not - but I suspect it won't. The >> > problem is, if a reviewer tries to land a patch from someone else >> > themselves, then arc seems to be most unhappy complaining about revisions. >> > >> > We need to work out the kinks in this process, But I think this can/will >> > streamline patch submission and review a lot for us. The phab web ui is not >> > bad at all for review. it's pretty much what gerrit is, just a bit >> > prettier. >> > >> > So sorry to the first few people being guinea pigs, but once this settles, >> > things will be better. :) I've at least documented what I know so far as >> > above. >> > >> > -- >> > ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> > The Rasterman (Carsten Haitzler) [email protected] >> > >> > >> > ------------------------------------------------------------------------------ >> > Everyone hates slow websites. So do we. >> > Make your web apps faster with AppDynamics >> > Download AppDynamics Lite for free today: >> > http://p.sf.net/sfu/appdyn_d2d_feb >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Everyone hates slow websites. So do we. >> Make your web apps faster with AppDynamics >> Download AppDynamics Lite for free today: >> http://p.sf.net/sfu/appdyn_d2d_feb >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
