On 04/04/2013 12:09 AM, Raphael Kubo da Costa wrote: > Simon <[email protected]> writes: > >> Simple fix for the main, that i modified from a version someone at >> SUSE did for something similar, basicly they added another param to >> some functions to return a error code. Our functions already had a >> error code but i thought it would be bad form to change the existing >> function behavior by returning a bunch of new errors that could >> conflict with existing code. I just added the error param and >> discarded the results, there's almost certainly a better way but this >> should be a good start for someone. > I'd rather just pass NULL as the last parameter to DGifOpen: the code is > explicitly designed not to fail or crash if it's NULL and we're not > using `err' for anything. No probs i'll generate a new patch with that tonight, libgif is by no means a area of expertise for me, i'm just trying to fix building efl with everything that will be in the next release of openSUSE
Cheers, Simon Lees, Co. Maintainer, Enlightenment on openSUSE ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
