On Fri, 4 Oct 2013 21:09:29 +0900 (KST) ChunEon Park <her...@naver.com> said:
> it shouldn't be in. maybe. > > but you made the function to return NULL. > > and then you want to know reason by other people? what tom is fishing for is.. you check for a null return and safely exit from the code... but tom thinks it should never be null. he wants to know what/in what setup it returns null. :) he wants it *IN* the commit message. i recently in the past week queried tom on an old commit of his that had a log message that was useless - i was trying to find out WHY he did something and the log didnt say it. :) > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Tom Hacohen"<tom.haco...@samsung.com> > To: <enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2013-10-04 (금) 19:59:02 > Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock > - null check." > > On 03/10/13 19:02, ChunEon Park wrote: > > If so, > > why dot you leave the evas_textblock_cursor_format_is_visible_get() to > > return NULL if you think it must verify the fnode? > > You missed the whole point of the revert. The point of the revert was my > inability to review your patch, and thus I couldn't assure it should be > kept in. Looking at it, it feels like it sholudn't be in, and without > proper explanation, I couldn't have been convinced. > > Maybe it doesn't verify the node, I don't remember, but again, read up. > > -- > Tom. > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
