If the function could return the NULL, then NULL check could be simply enough description I think
Otherwise, I agree those commits are totally wrong and may need more descrive messages. I didn't oppose you yet. But the function(_evas_textblock_node_visible_at_pos_get) code has the case to return NULL explicitly still, So I asked you why do you leave the function to return NULL case if you don't agree on it. You didn't answer at all but only focused on the commit message that could be depeneded on the function do. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<tom.haco...@samsung.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2013-10-04 (금) 22:54:39 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check." On 04/10/13 14:47, Carsten Haitzler (The Rasterman) wrote: > On Fri, 4 Oct 2013 21:09:29 +0900 (KST) ChunEon Park <hermet>@naver.com> said: > >> it shouldn't be in. maybe. >> >> but you made the function to return NULL. >> >> and then you want to know reason by other people? > > what tom is fishing for is.. you check for a null return and safely exit from > the code... but tom thinks it should never be null. he wants to know what/in > what setup it returns null. :) he wants it *IN* the commit message. > > i recently in the past week queried tom on an old commit of his that had a log > message that was useless - i was trying to find out WHY he did something and > the > log didnt say it. :) Exactly! Well the log did say it, but unfortunately in a language only I understand. :) I managed to decrypt that message, but this message from Hermet I wasn't able to. I am a sinner, just like the rest of us. -- Tom. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
