On Tue, 17 Dec 2013 20:38:33 -0600 Nick Reed <[email protected]> said: > On Dec 17, 2013, at 7:00 PM, Carsten Haitzler (The Rasterman) > <[email protected]> wrote: > > > On Tue, 17 Dec 2013 17:22:52 -0600 Nick Reed <[email protected]> said: > > > >> Cross compiling for an ARM platform, I ran into compile issues with > >> src/lib/evas/common/evas_scale_smooth.c. > >> > >> The existing BUILD_NEON code doesn't follow the same idiom as MMX, for > >> instance, with naming of the function created in evas_scale_smooth_scaler.c > >> with a leading underscore, and creating an EAPI function in > >> evas_scale_smooth.h to adapt parameters to the generated function. Best I > >> can tell there is no way the BUILD_NEON code could compile for anyone. > >> It's a straightforward fix to get it to compile. > >> > >> Am I off base here? Should I submit a patch? > > > > it builds perfectly for me. i actually build it a few times per week on my > > nexus7... :) > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > >
gah! i found out why.. it's never been enabling neon code in my builds - ever. because i wans't adding -mfpu=neon in my CFLAGs.. thus architecture was not detected as a neon capable arch/compiler. gah! > I don't think I have any odd configure options, it doesn't look like any of > that conditionally compiles, and I and my compiler seem to agree on a > problem. I apologize if I'm being obtuse. > > evas_common_scale_rgba_in_to_out_clip_smooth_mmx and > evas_common_scale_rgba_in_to_out_clip_smooth_c match signatures with > Evas_Command_Scale_In_To_Out_Clip_Cb: 11 parameters. > > evas_common_scale_rgba_in_to_out_clip_smooth_neon gets called as if it were, > and assigned to a variable of type Evas_Command_Scale_In_To_Out_Clip_Cb. > > The only definition of evas_common_scale_rgba_in_to_out_clip_smooth_neon is > here: > > #ifdef BUILD_NEON > # undef SCALE_FUNC > # undef SCALE_USING_NEON > # define SCALE_USING_NEON > # define SCALE_FUNC evas_common_scale_rgba_in_to_out_clip_smooth_neon > # include "evas_scale_smooth_scaler.c" > # undef SCALE_USING_NEON > #endif > > And evas_scale_smooth_scaler.c defines a function named SCALE_FUNC taking 16 > params. Every non-neon instance declares SCALE_FUNC with a leading > underscore, and wraps the call in a function that adapts the 11 param call to > 16. > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
