On Dec 18, 2013, at 2:15 AM, Carsten Haitzler (The Rasterman) <[email protected]> wrote:
> On Tue, 17 Dec 2013 20:38:33 -0600 Nick Reed <[email protected]> said: > >> On Dec 17, 2013, at 7:00 PM, Carsten Haitzler (The Rasterman) >> <[email protected]> wrote: >> >>> On Tue, 17 Dec 2013 17:22:52 -0600 Nick Reed <[email protected]> said: >>> >>>> Cross compiling for an ARM platform, I ran into compile issues with >>>> src/lib/evas/common/evas_scale_smooth.c. >>>> >>>> The existing BUILD_NEON code doesn't follow the same idiom as MMX, for >>>> instance, with naming of the function created in evas_scale_smooth_scaler.c >>>> with a leading underscore, and creating an EAPI function in >>>> evas_scale_smooth.h to adapt parameters to the generated function. Best I >>>> can tell there is no way the BUILD_NEON code could compile for anyone. >>>> It's a straightforward fix to get it to compile. >>>> >>>> Am I off base here? Should I submit a patch? >>> >>> it builds perfectly for me. i actually build it a few times per week on my >>> nexus7... :) >>> >>> >>> -- >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>> The Rasterman (Carsten Haitzler) [email protected] >>> > > gah! i found out why.. it's never been enabling neon code in my builds - ever. > because i wans't adding -mfpu=neon in my CFLAGs.. thus architecture was not > detected as a neon capable arch/compiler. gah! > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] I've attached a simple patch to resolve the build issue. Just mirrored what exists for MMX. I have not added an EAPI function definition in the header file at this point. I'm not sure if that's desired as well to match. Additionally, I have attempted to file a patch through arcanist. ( https://phab.enlightenment.org/D424 ) This should fix the error Jeff Hoogland reported over the weekend. ( Subject: Issue Build EFL 1.8.3 )
0001-evas-fix-neon-scale-code.patch
Description: Binary data
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
