On 31/12/13 11:33, Jaehyun Cho wrote: > - elm_widget_mirrored_set(obj, elm_config_mirrored_get()); > + priv->is_mirrored = elm_config_mirrored_get();
This looks very wrong and bad practice. What happens if I'll change elm_widget_mirrored_set()? Things will break... Unless you have a really good reason for doing that (which you don't, there's no good reason). I suggest this patch will be amended. -- Tom. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
