The function is intended commonly used in everytime, but the case can be exceptionally cared at least right this moment, since it's in initialization time. Sometimes this could be rather simpler and easier to understand and maintain like "goto" statement.
If you don't like the code, then you can do refactoring it by yourself. I have no reason to make it safer code because currently already it is, And most of all, I don't want make it more complex since I'm not sure what will be exactly changed in the future. we can refactoring it later when the requirement is acutally happened. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<tom.haco...@samsung.com> To: <enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2014-01-08 (수) 00:03:51 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: [elm_widget] Fix not to load theme for mirroring if smart data is not set On 07/01/14 14:50, ChunEon Park wrote: > I don't agree that your suggestion makes the code simpler and easier to > maintain. > current is the most simplest and no problem. > > The worst base codebase is caused by exorbitant concern like you. > concern is just concern. it's not true. > you are not prophet and your concern is not always true. You are setting a private flag on an object not using the functions that are there to modify it. If someone decides to change something that's done when changing the property (for example, now there's theme_set going there, but it could be anything, like another flag) everything will break because of it. Of course I'm not a prophet, and heck, in this case (mirroring), nothing bad will probably happen, as this code is unlikely (though might) to change. Concerns don't always come to life, but this is not some apocalyptic prophecy, this is a real life example that has similar things all around the place. Having multiple points of entry to a specific property is not a good idea. Do you not agree? -- Tom. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
