Hello. On Fri, 2014-01-17 at 11:08, Daniel Kolesa wrote: > quaker pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=6db16915951af61d28f62f4de7c14c76e4303f18 > > commit 6db16915951af61d28f62f4de7c14c76e4303f18 > Author: Daniel Kolesa <[email protected]> > Date: Fri Jan 17 19:07:59 2014 +0000 > > edje: use luajit by default, if you want lua use --enable-lua-old
I'm unhappy with this commit. Where and when was it decided to switch on a new default dependency? For instance jenkins is broken for all efl related builds now because nobody told me or beber in advance that luajit will be needed from now on. And as I have a busy weekend I will only be anle to look into this from Monday. I think something like this should be communicated before the actual change hits the repo. Second, 90% of this patch is indent changes not related to enable luajit. Meaning there is tons of noise in this commit before I can actually see what did change. And yes, I was looking through this commit to see what it did to break the build. Lucky enough it hit the repo during the merge window or I would have reverted it in an instant. regards Stefan Schmidt ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
