On Thu, 6 Feb 2014 08:32:46 +0900 Carsten Haitzler (The Rasterman) <ras...@rasterman.com> wrote:
> On Wed, 5 Feb 2014 18:24:31 -0500 Michael Blumenkrantz > <michael.blumenkra...@gmail.com> said: > > > On Thu, 6 Feb 2014 08:13:16 +0900 > > Carsten Haitzler (The Rasterman) <ras...@rasterman.com> wrote: > > > > > On Wed, 5 Feb 2014 12:43:34 -0500 Michael Blumenkrantz > > > <michael.blumenkra...@gmail.com> said: > > > > > > > On Wed, 05 Feb 2014 09:08:06 -0800 > > > > Carsten Haitzler <ras...@rasterman.com> wrote: > > > > > > > > > raster pushed a commit to branch master. > > > > > > > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=3d0eb4137359134eac2c815194a34472e2762c03 > > > > > > > > > > commit 3d0eb4137359134eac2c815194a34472e2762c03 > > > > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > > > > Date: Thu Feb 6 02:03:46 2014 +0900 > > > > > > > > > > theme - remove shadow from border now comp provides it again > > > > > --- > > > > > data/themes/edc/border.edc | 46 + > > > > > +-------------------------------------------- 1 file changed, 2 > > > > > insertions (+), 44 deletions(-) > > > > > > > > > > > > > > > > > this was left intentionally. shadows here are still used any time > > > > there's > > > > a window frame since you had wanted all shadows moved to this object in > > > > E18. > > > > > > well then all windows got 2 shadows. you didn't notice the shadows became > > > twice as dark? there's a bug then. choose. border or comp provides > > > shadow. :) not both. > > > > > > > yes...that was my point to you, since you were the decider who said to put > > it > > into the border theme. it's easier to leave it in comp. > > it SHOULD be in the border because it is the border shape that casts the > shadow. example - imagine the border was a set of ivy leaves (not square) and > they changed look/shape as the border resized or even animated. > > but as such we had a visual bug here so one of the shadows had to go. maybe > the > borderless window frame (as it is actually an edje group) should have just a > shadow by itself? but then we have a problem - we have to add or remove this > shadow based on the client argb/shape status. border remembers/matches do not > have this ability so it'd have to be done in code as a special choice - > "borderless" vs "borderless-plain" (no shadow) done in code. > what you're describing here with the shadow on the frame is exactly what you tried to remove with this commit, so I'm not sure how that works. if there were double shadows, then that's just a problem with signalling and has nothing to do with the theme. ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
