yakov pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=f3018a54d9c40fffe60687f020f0acd1e5ea4d87

commit f3018a54d9c40fffe60687f020f0acd1e5ea4d87
Author: Yakov Goldberg <yako...@samsung.com>
Date:   Mon Feb 24 14:15:46 2014 +0200

    menu: add NULL checks to elm_obj_menu_item_add()
    
       Function returns newly created item through last param
       Elm_Object_Item**. Add checks to make possible to pass NULL,
       if return is not needed.
---
 src/lib/elm_menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_menu.c b/src/lib/elm_menu.c
index cbbadad..7f20f0d 100644
--- a/src/lib/elm_menu.c
+++ b/src/lib/elm_menu.c
@@ -965,7 +965,7 @@ _item_add(Eo *obj, void *_pd, va_list *list)
    Evas_Smart_Cb func = va_arg(*list, Evas_Smart_Cb);
    const void *data = va_arg(*list, const void *);
    Elm_Object_Item **ret = va_arg(*list, Elm_Object_Item **);
-   *ret = NULL;
+   if (ret) *ret = NULL;
 
    Elm_Menu_Item *it;
    Evas_Object *icon_obj;
@@ -1009,7 +1009,7 @@ _item_add(Eo *obj, void *_pd, va_list *list)
      it->dbus_idx = _elm_dbus_menu_item_add(sd->dbus_menu, (Elm_Object_Item 
*)it);
      it->dbus_menu = sd->dbus_menu;
    }
-   *ret = (Elm_Object_Item *)it;
+   if (ret) *ret = (Elm_Object_Item *)it;
 }
 
 EAPI unsigned int

-- 


Reply via email to