On Tue, May 6, 2014 at 11:38 AM, Tom Hacohen <[email protected]> wrote: > On 06/05/14 05:13, Lucas De Marchi wrote: >> On Tue, May 06, 2014 at 12:58:10AM -0300, Lucas De Marchi wrote: >>> On Sat, May 3, 2014 at 6:57 PM, Cedric BAIL <[email protected]> wrote: >>>> On Sat, May 3, 2014 at 9:53 PM, Daniel Juyung Seo <[email protected]> >>>> wrote: >>>>> Well, I don't think this can go in at this stage as we're in a feature >>>>> freeze. >>>> >>>> Yes and no :-) It has been discussed on IRC (we should have pointed >>>> that on the ML to), but as it is not a public API, is not used by >>>> anything inside our build, and we want people to look at the result >>>> early, it was decided that this could still get in during this week >>>> (The patch has been in discussion for some time on phab already). >>>> >>>>> This also broke the build. >>>>> Can you check this again? >>>> >>>> This is something I tried to understand but the build break in the >>>> middle of nowhere and I couldn't make sense of it. So I was thinking >>>> it was a temporary failure, if anyone has a better explanation :-) >>> >>> So, as far as I understood an experimental thing that can not even be >>> disabled?? Build is broken if you don't build in the src tree. I.e. >>> make distcheck is broken >>> >>> And there are gazillions of warnings introduced all over eolian >> >> With the following patch I could at least get the build to complete. Still >> lots >> of errors eolian is giving such as: >> >> ERR<26616>:eolian /home/lucas/p/e//efl/src/lib/eolian/eolian_database.c:539 >> eolian_class_function_find_by_name() Function destructor not found in class >> Eo_Base >> EOLCXX lib/ecore/ecore_idle_exiter.eo.hh >> ERR<26670>:eolian /home/lucas/p/e//efl/src/lib/eolian/eolian_database.c:539 >> eolian_class_function_find_by_name() Function destructor not found in class >> Eo_Base >> EOLCXX lib/ecore/ecore_animator.eo.hh >> >> ... >> >> and C++ warnings as well. > > Yeah, a ton of both. This is just crazy. What happened to compiling > before pushing? I'm pointing my finger at both the original author and > the pusher.
I love how you live in a simple world :-) Most of my patch where on top Felipe's patch from February 28. I hope some people did compile it since then, but none did detect the problem or report it. I am guessing that most people don't run make check and only packager on older distro will have detected the problem. So even if eolian_cxx did introduce some problem, it did mostly reveal existing one. That would have been detected way to late in our release cycle as packager tend to start packaging on the release tarball. -- Cedric BAIL ------------------------------------------------------------------------------ Is your legacy SCM system holding you back? Join Perforce May 7 to find out: • 3 signs your SCM is hindering your productivity • Requirements for releasing software faster • Expert tips and advice for migrating your SCM now http://p.sf.net/sfu/perforce _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
