> Not sure how you got /usr/share to be duplicated, it is not the case
here...

That's exactly what my patch does :), as:

> % echo $XDG_DATA_DIRS | tr ':' '\n' | sort
> /opt/e/share
> /opt/e/share/enlightenment
> /usr/local/share
> /usr/share

for your case, since you don't have /usr as default prefix it doesn't bugs
to you,  but /usr is the most common prefix, the bug happens only when the
default prefix is /usr, by adding it before is added statically (as like in
your last line)

> Also, you should remove 'p' in the first snprintf line :)

right! corrected in another commit:  http://pastebin.com/xrB51sXW

> So... is it really bad to have duplicates in XDG_DATA_DIRS?

first, .desktop files would appear in the wrong order (overwrite one by
other, priority listing of them), also it may probably increase twice
the amount of processed data (.desktop files scanning, which almost all are
in /usr/share), and there's also a small bug that icons changes from one to
other very fastly when you do alt-tab, but i dont know from where this bug
comes from, it can be related :)



2014-12-24 2:16 GMT+01:00 Jean-Philippe André <j...@videolan.org>:

> Hi,
>
> Not sure how you got /usr/share to be duplicated, it is not the case
> here...
>
> On Wed, Dec 24, 2014 at 1:13 AM, Thanatermesis <
> thanatermesis.e...@gmail.com
> > wrote:
>
> > If you run:
> >
> >     echo $XDG_DATA_DIRS | tr ':' '\n' | sort
> >
> > you will see that you have a duplicated one
> >
>
>  % echo $XDG_DATA_DIRS | tr ':' '\n' | sort
> /opt/e/share
> /opt/e/share/enlightenment
> /usr/local/share
> /usr/share
>
>
> >
> > So I did this commit  http://pastebin.com/9BUnzrHu  which works on both
> > e17
> > and master branches, where it fixes the problem, as we can see in
> > https://www.enlightenment.org/ss/e-54998c1c35fdd0.34968942.jpg
> >
> > Lacking of time that somebody checks the commit before to do any push I
> > ended to pushing it only to my own remote (everybody on christmas? yeah i
> > should go too!)
> >
> > So... what do you think? I should push this commit? anything to change?
> >
>
>
> Did you have /usr as prefix for EFL but not for E?
> Also, you should remove 'p' in the first snprintf line :)
>
> So... is it really bad to have duplicates in XDG_DATA_DIRS?
> If it is, then something smarter than just checking for /usr should
> probably be implemented.
>
> Best regards,
>
> --
> Jean-Philippe André
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is
> your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to