Hi, On Wed, Apr 15, 2015 at 3:19 PM, Stefan Schmidt <ste...@datenfreihafen.org> wrote:
> Hello. > > You realize we are in freeze for 1.14? > > This is adding a new EAPI without even having a user for it. > > If you want to keep this in I would need to hear a good justification > for it. > Yep. I already spoke to him about that (see IRC... and uh... IRL). This patch is not critical, since it's here to prevent API misuses. But: - It's a BETA EAPI (because it's Eo) - It's also pretty minor See https://phab.enlightenment.org/D2346 for a use case. Jaehwan argues that all constructors calling eo_super_do() should probably do that error_get() api in order to fail early and not return an invalid object. This is of course debatable, so please argue. Cheers, jp > > regards > Stefan Schmidt > > On 15/04/15 06:58, Jaehwan Kim wrote: > > jaehwan pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=537c7fe9e3a72242c386b8851dd450fdc6312171 > > > > commit 537c7fe9e3a72242c386b8851dd450fdc6312171 > > Author: Jaehwan Kim <jae.hwan....@samsung.com> > > Date: Wed Apr 15 13:52:01 2015 +0900 > > > > eo: add eo_error_get > > > > This is pair of eo_error_set. > > --- > > src/lib/eo/Eo.h | 13 +++++++++++++ > > src/lib/eo/eo.c | 8 ++++++++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/src/lib/eo/Eo.h b/src/lib/eo/Eo.h > > index 46e9d73..96e5c37 100644 > > --- a/src/lib/eo/Eo.h > > +++ b/src/lib/eo/Eo.h > > @@ -631,6 +631,19 @@ EAPI const Eo_Class *eo_class_get(const Eo *obj); > > EAPI void eo_error_set_internal(const Eo *obj, const char *file, int > line); > > /* @endcond */ > > > > +/** > > + * @def eo_error_get > > + * @brief Get whether or not the eo has error when constructing, > destructing or calling a function of the object. > > + * @param obj the object to work on. > > + * > > + * @see eo_error_set() > > + */ > > +#define eo_error_get(obj) eo_error_get_internal(obj) > > + > > +/* @cond 0 */ > > +EAPI Eina_Bool eo_error_get_internal(const Eo *obj); > > +/* @endcond */ > > + > > #define _eo_add_common(klass, parent, is_ref, ...) \ > > ( \ > > _eo_do_start(_eo_add_internal_start(__FILE__, __LINE__, klass, > parent, is_ref), \ > > diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c > > index 166e638..bcc1796 100644 > > --- a/src/lib/eo/eo.c > > +++ b/src/lib/eo/eo.c > > @@ -1584,6 +1584,14 @@ eo_error_set_internal(const Eo *obj_id, const > char *file, int line) > > obj->do_error = EINA_TRUE; > > } > > > > +EAPI Eina_Bool > > +eo_error_get_internal(const Eo *obj_id) > > +{ > > + EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_TRUE); > > + > > + return obj->do_error; > > +} > > + > > void > > _eo_condtor_done(Eo *obj_id) > > { > > > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Jean-Philippe André ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
