On 04/15/2015 09:32 AM, Stefan Schmidt wrote:
> Hello.
>
> On 14/04/15 22:57, Dave Andreoli wrote:
>> davemds pushed a commit to branch master.
>>
>> http://git.enlightenment.org/core/elementary.git/commit/?id=d021b7e36d001ecdeb3767bb6a67cc361d0f7ee9
>>
>> commit d021b7e36d001ecdeb3767bb6a67cc361d0f7ee9
>> Author: Dave Andreoli <d...@gurumeditation.it>
>> Date: Tue Apr 14 22:19:18 2015 +0200
>>
>> Add missing file_get legacy definition for Video and Layout
>>
>> was missed from commit:
>> e5cda41c889f98b6f3f5f63b909f595a7a656cc0
> If these legacy defines have only been forgotten it is totally fine to
> add them now. I just want to hear from Yakov if he really forgot or if
> he had a reason not adding them but forgot to say so in the commit
> message. Yakov?
I didn't add these legace APIs because they have never existed.
I just added FILE interface implementations for Layout and Video to
avoid error message.
So do we need them now?
>
> regards
> Stefan Schmidt
>
>
>> ---
>> src/lib/elm_layout.c | 6 ++++++
>> src/lib/elm_layout_legacy.h | 13 +++++++++++++
>> src/lib/elm_video.c | 6 ++++++
>> src/lib/elm_video_legacy.h | 12 ++++++++++++
>> 4 files changed, 37 insertions(+)
>>
>> diff --git a/src/lib/elm_layout.c b/src/lib/elm_layout.c
>> index 19f6b47..f04b80f 100644
>> --- a/src/lib/elm_layout.c
>> +++ b/src/lib/elm_layout.c
>> @@ -1725,4 +1725,10 @@ elm_layout_file_set(Eo *obj, const char *file, const
>> char *group)
>> return eo_do_ret((Eo *) obj, ret, efl_file_set(file, group));
>> }
>>
>> +EAPI void
>> +elm_layout_file_get(Eo *obj, const char **file, const char **group)
>> +{
>> + eo_do((Eo *) obj, efl_file_get(file, group));
>> +}
>> +
>> #include "elm_layout.eo.c"
>> diff --git a/src/lib/elm_layout_legacy.h b/src/lib/elm_layout_legacy.h
>> index 1df030d..e5bd857 100644
>> --- a/src/lib/elm_layout_legacy.h
>> +++ b/src/lib/elm_layout_legacy.h
>> @@ -88,4 +88,17 @@ EAPI Evas_Object
>> *elm_layout_content_unset(Evas_Object *obj, con
>> */
>> EAPI Eina_Bool elm_layout_file_set(Eo *obj, const char *file, const char
>> *group);
>>
>> +/**
>> + * Get the loaded file
>> + *
>> + *
>> + * @ingroup Layout
>> + *
>> + * @param file The path to file (edj) used as layout
>> + * @param group The group that the layout belongs in edje file
>> + *
>> + * @since 1.14
>> + */
>> +EAPI void elm_layout_file_get(Eo *obj, const char **file, const char
>> **group);
>> +
>> #include "elm_layout.eo.legacy.h"
>> diff --git a/src/lib/elm_video.c b/src/lib/elm_video.c
>> index b90e3f9..56f8ad0 100644
>> --- a/src/lib/elm_video.c
>> +++ b/src/lib/elm_video.c
>> @@ -460,5 +460,11 @@ elm_video_file_set(Eo *obj, const char *filename)
>> return eo_do_ret((Eo *) obj, ret, efl_file_set(filename, NULL));
>> }
>>
>> +EAPI void
>> +elm_video_file_get(Eo *obj, const char **filename)
>> +{
>> + eo_do((Eo *) obj, efl_file_get(filename, NULL));
>> +}
>> +
>>
>> #include "elm_video.eo.c"
>> diff --git a/src/lib/elm_video_legacy.h b/src/lib/elm_video_legacy.h
>> index 82e4191..184d31a 100644
>> --- a/src/lib/elm_video_legacy.h
>> +++ b/src/lib/elm_video_legacy.h
>> @@ -48,4 +48,16 @@ the available Webcam on your system).
>> */
>> EAPI Eina_Bool elm_video_file_set(Eo *obj, const char *filename);
>>
>> +/**
>> + *
>> + * @brief Get the file or URI that is used as the video source.
>> + *
>> + * @ingroup Video
>> + *
>> + * @param filename The file or URI.
>> + *
>> + * @since 1.14
>> + */
>> +EAPI void elm_video_file_get(Eo *obj, const char **filename);
>> +
>> #include "elm_video.eo.legacy.h"
>>
>
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
