On 15/04/15 19:54, Davide Andreoli wrote: > 2015-04-15 10:06 GMT+02:00 Yakov Goldberg <yako...@samsung.com>: > >> On 04/15/2015 09:32 AM, Stefan Schmidt wrote: >>> Hello. >>> >>> On 14/04/15 22:57, Dave Andreoli wrote: >>>> davemds pushed a commit to branch master. >>>> >>>> >> http://git.enlightenment.org/core/elementary.git/commit/?id=d021b7e36d001ecdeb3767bb6a67cc361d0f7ee9 >>>> >>>> commit d021b7e36d001ecdeb3767bb6a67cc361d0f7ee9 >>>> Author: Dave Andreoli <d...@gurumeditation.it> >>>> Date: Tue Apr 14 22:19:18 2015 +0200 >>>> >>>> Add missing file_get legacy definition for Video and Layout >>>> >>>> was missed from commit: >>>> e5cda41c889f98b6f3f5f63b909f595a7a656cc0 >>> If these legacy defines have only been forgotten it is totally fine to >>> add them now. I just want to hear from Yakov if he really forgot or if >>> he had a reason not adding them but forgot to say so in the commit >>> message. Yakov? >> I didn't add these legace APIs because they have never existed. >> I just added FILE interface implementations for Layout and Video to >> avoid error message. >> So do we need them now? >> > > We have the setter definition in the legacy api, why not the getter? > Is there a reason?
Yes, setter was there, getter was not. These changes just mimiced the old legacy api. They are not about writing fix the API just yet. -- Tom. ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
