On Mon, May 11, 2015 at 5:37 PM, Tom Hacohen <t...@osg.samsung.com> wrote:
> On 11/05/15 09:33, Jean-Philippe André wrote: > > Hi, > > > > On Thu, May 7, 2015 at 2:22 AM, Tom Hacohen <t...@stosb.com> wrote: > > > >> tasn pushed a commit to branch master. > >> > >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=7c2d0453757fd6fc712f5dcef70f33daa2871fb3 > >> > >> commit 7c2d0453757fd6fc712f5dcef70f33daa2871fb3 > >> Author: Tom Hacohen <t...@stosb.com> > >> Date: Wed May 6 18:19:42 2015 +0100 > >> > >> Evas gl: Fix shader generation with out of source builds. > >> > >> It's actually still stupid and broken, but at least less. It > shouldn't > >> generate them in source, but out of source, I don't understand how > this > >> even passes distcheck. Actually, my changes might break distcheck > >> because now it actually does what it says it does, and thus might > break > >> things. > >> > > > > > > Those shaders (two .x files) should not be generated unless you actually > > changed the script or .shd files. The generation thing is indeed a bit > > stupid and was not meant to work perfectly like eolian on all platforms > > (it's a bash script). > > > > That's why the .x files are shipped in Git, they are not meant to change, > > unless you go and modify the GLSL code itself. > > > > Do you have any idea why the generation gets run on your machine? Is this > > after a fresh checkout? (in which case maybe a .shd file is modified > after > > the .x files) > > > > Fresh build (old check out). I fixed the broken building now, but it's > still wrong. You shouldn't generate files in the source dir automatically. > > Yeah. They shouldn't be generated. Only when a dev changes the shd files, the .x files should be changed and pushed to git. That's why I'm asking... why did they get generated? Bad timestamps somehow? -- Jean-Philippe André ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
