Hello,
On Sat, Aug 15, 2015 at 7:14 PM, Amitesh Singh <singh.amit...@gmail.com> wrote: > Hello Raster, > > > On Thu, Aug 13, 2015 at 4:07 PM, Carsten Haitzler <ras...@rasterman.com> > wrote: > >> On Thu, 13 Aug 2015 14:18:38 +0900 Carsten Haitzler (The Rasterman) >> <ras...@rasterman.com> said: >> >> > On Thu, 13 Aug 2015 09:01:53 +0530 Amitesh Singh < >> singh.amit...@gmail.com> >> > said: >> > >> > > On Aug 13, 2015 1:58 AM, "Davide Andreoli" <d...@gurumeditation.it> >> wrote: >> > > > >> > > > 2015-08-12 20:47 GMT+02:00 Amitesh Singh <singh.amit...@gmail.com>: >> > > > >> > > > > Hello, >> > > > > >> > > > > >> > > > > On Wed, Aug 12, 2015 at 9:45 PM, Amitesh Singh < >> singh.amit...@gmail.com> >> > > > > wrote: >> > > > > >> > > > > > Hello, >> > > > > > >> > > > > > I will be making scroller optional in popup. will raise patch >> soon. >> > > > > > >> > > > > > Thanks >> > > > > > Amitesh >> > > > > > >> > > > > > >> > > > > Please review following patch. >> > > > > >> > > > > https://phab.enlightenment.org/D2945 >> > > > > >> > > > > >> > > > Hi, we are going to packport this to 1.15 branch? right? >> > > > thus it should be @since 1.15.1... no? >> > > > >> > > >> > > Yes. It should be 1.15. Thanks for pointing out. >> > > >> > > > Is the "min:240 0;" line in the edc really needed? that is the line >> that >> > > > caused the brackage of custom themes, and can probably cause >> > > > other issue in the future (for themes that do not have that line) >> > > > >> > > >> > > It is needed to make scroller enabled popup to work but you are right. >> > > >> > > Should we add new theme for scroll enabled popup? >> > >> > here is my take - no. we don't scroller is added optionally if enabled >> by api. >> > old code continues as normal. NEW code, if it enables this, the popup >> has to >> > expand to "fill the parent". i don't think you need a new group for >> this - >> > just a signal to say "fill" or not. >> >> we need a bit more than this actually... we also need to know if the theme >> understands this new signal - so it needs to set some data key to indicate >> this. if ti doesn't we have to FORCe the content of the popup IF we >> enabled a >> scroller to be some minimum width at the code level. (eg when putting >> scroller >> in put scroller in table, put another rect in table, set min width of >> rect to >> some magic fixed value * scaling factor to force a min width on the >> scroller - >> and maybe a min height too) >> >> > Then, we don't need C API for enabling scroll? > > > I understood now why both data item in theme and C API are needed. https://phab.enlightenment.org/D2945 is updated. > > > > cheers >> > > > >> > > > >> > > > > > >> > > > > > On Wed, Aug 12, 2015 at 8:52 PM, Jeff Hoogland < >> jeffhoogl...@linux.com >> > > > >> > > > > > wrote: >> > > > > > >> > > > > >> At least we've pinned it down. Looking forward to EFL / Elm >> 1.15 so I >> > > > > can >> > > > > >> finally get Bodhi off of 1.12.x branch. >> > > > > >> >> > > > > >> On Tue, Aug 11, 2015 at 8:58 PM, Carsten Haitzler < >> > > ras...@rasterman.com >> > > > > > >> > > > > >> wrote: >> > > > > >> >> > > > > >> > On Tue, 11 Aug 2015 14:44:25 +0200 Davide Andreoli < >> > > > > >> d...@gurumeditation.it >> > > > > >> > > >> > > > > >> > said: >> > > > > >> > >> > > > > >> > > 2015-08-11 2:08 GMT+02:00 Carsten Haitzler < >> ras...@rasterman.com >> > > >: >> > > > > >> > > >> > > > > >> > > > On Mon, 10 Aug 2015 08:15:05 -0500 Jeff Hoogland >> > > > > >> > <jeffhoogl...@linux.com> >> > > > > >> > > > said: >> > > > > >> > > > >> > > > > >> > > > > Apparently this issue is related to my Elm theme. >> > > > > >> > > > > >> > > > > >> > > > > Are we ever going to stop breaking the theme API? >> > > > > >> > > > >> > > > > >> > > > we didn't break theme api. perhaps your theme was broken >> to >> > > begin >> > > > > >> with >> > > > > >> > and >> > > > > >> > > > only >> > > > > >> > > > now is showing up? you do claim to not know edje at all >> and >> > > thus >> > > > > it >> > > > > >> is >> > > > > >> > > > quite >> > > > > >> > > > likely that this is the case. >> > > > > >> > > > >> > > > > >> > > >> > > > > >> > > No, raster, you are wrong: we didn't change the theme api, >> but we >> > > > > >> > probably >> > > > > >> > > changed >> > > > > >> > > the behavior, I think that the offending commit is: >> > > > > >> > >> > > > > >> > that's a bug. we should have no theme api breaks (unless as >> tom >> > > said >> > > > > >> > before - >> > > > > >> > it was already fundamentally broken and unusable anyway). >> > > > > >> > >> > > > > >> > > >> > > > > >> > >> > > > > >> >> > > > > >> > > >> https://phab.enlightenment.org/rELM9c8ddce6179253487dd01730a55de1f5273b498e >> > > > > >> > > >> > > > > >> > > There is a "min: 240 0;" added to the >> > > > > >> "elm/popup/content/popup/default" >> > > > > >> > > group. >> > > > > >> > > The lacks of MIN in older themes cause the popups to show >> up >> > > > > shrinked >> > > > > >> > > in elm 1.15. >> > > > > >> > >> > > > > >> > i'ts a bug... and it appears my advice was not heeded - make >> the >> > > > > >> scroller >> > > > > >> > an >> > > > > >> > explicit option you enable for new behavior. then nothing >> > > > > >> changes/breaks... >> > > > > >> > unless someone asks for the new feature (and thus have to >> deal with >> > > > > the >> > > > > >> > implications - eg if popup isnt set to expand on its own - eg >> > > > > >> weight/fill >> > > > > >> > wise, >> > > > > >> > then it will squash content down to almost nothing due to >> > > scroller). >> > > > > >> > >> > > > > >> > the point here is - this is a bug. theme api didn't change. >> someone >> > > > > >> added a >> > > > > >> > feature in a way that breaks existing behavior. :) >> > > > > >> > >> > > > > >> > > > just saying - making an assumption like "it only affects >> my >> > > theme, >> > > > > >> > thus the >> > > > > >> > > > theme api broke" is a pretty poor assumption to make. >> > > > > >> > > > >> > > > > >> > > > if i wrote an app that accessed memory after it was >> freed - >> > > > > >> immediately >> > > > > >> > > > after, >> > > > > >> > > > and it worked for years, then suddenly started >> crashing.. and i >> > > > > >> blame >> > > > > >> > the >> > > > > >> > > > kernel devs or libc devs for breaking api... what do you >> think >> > > the >> > > > > >> > response >> > > > > >> > > > would be? >> > > > > >> > > > >> > > > > >> > > > before launching into "it's a theme api break" which we >> have >> > > been >> > > > > >> very >> > > > > >> > > > careful >> > > > > >> > > > to not do, how about know the root cause first? eg - >> what is >> > > the >> > > > > >> > difference >> > > > > >> > > > between your theme and default in this scenario that >> causes >> > > this >> > > > > >> > change? >> > > > > >> > > > you >> > > > > >> > > > also know that depending on situation themes can be >> timing >> > > > > sensitive >> > > > > >> > > > because >> > > > > >> > > > they may react to signals that then generate more >> signals that >> > > > > >> generate >> > > > > >> > > > more... >> > > > > >> > > > etc. and different themes may generate different signals >> and >> > > > > >> different >> > > > > >> > > > sequences and amounts. >> > > > > >> > > > >> > > > > >> > > > > On Mon, Aug 10, 2015 at 8:07 AM, Jeff Hoogland < >> > > > > >> > jeffhoogl...@linux.com> >> > > > > >> > > > > wrote: >> > > > > >> > > > > >> > > > > >> > > > > > I think my issue is different from yours as it is >> still >> > > > > present >> > > > > >> in >> > > > > >> > the >> > > > > >> > > > > > release tar. >> > > > > >> > > > > > >> > > > > >> > > > > > This one is going to block me from releasing 1.15 to >> the >> > > Bodhi >> > > > > >> > stable >> > > > > >> > > > repo >> > > > > >> > > > > > since it breaks one of our default applications. >> > > > > >> > > > > > >> > > > > >> > > > > > On Fri, Aug 7, 2015 at 3:39 AM, Tom Hacohen < >> > > > > >> t...@osg.samsung.com> >> > > > > >> > > > wrote: >> > > > > >> > > > > > >> > > > > >> > > > > >> On 06/08/15 23:37, Jeff Hoogland wrote: >> > > > > >> > > > > >> > Finally got around to getting on the latest EFL / >> Elm >> > > with >> > > > > >> the >> > > > > >> > > > latest >> > > > > >> > > > > >> > release. One of my popups in epad is messed up >> with this >> > > > > >> > version. >> > > > > >> > > > This >> > > > > >> > > > > >> is >> > > > > >> > > > > >> > what it looks like with EFL / ELM 1.12: >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > >> > > > > >> https://www.enlightenment.org/ss/e-55c3e0bcda5169.10806046.jpg >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > And with EFL / ELM 1.15: >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > >> > > > > >> https://www.enlightenment.org/ss/e-55c3dfa2431c27.18476780.jpg >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > Same exact code for both images. >> > > > > >> > > > > >> > >> > > > > >> > > > > >> > Source is here < >> > > > > >> > > > https://github.com/JeffHoogland/ePad/blob/master/epad>, >> > > > > >> > > > > >> > popup is built starting at line 449. >> > > > > >> > > > > >> > >> > > > > >> > > > > >> >> > > > > >> > > > > >> Weird, my email from last night never went through. >> > > > > >> > > > > >> >> > > > > >> > > > > >> Anyhow, as I said there, I already spotted it, >> opened a >> > > > > ticket, >> > > > > >> > and it >> > > > > >> > > > > >> was meant to be fixed: >> > > https://phab.enlightenment.org/T2623 >> > > > > >> > > > > >> >> > > > > >> > > > > >> Is it not? :( >> > > > > >> > > > > >> >> > > > > >> > > > > >> -- >> > > > > >> > > > > >> Tom. >> > > > > >> > > > > >> >> > > > > >> > > > > >> >> > > > > >> > > > > >> >> > > > > >> > > > >> > > > > >> > >> > > > > >> >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > >> > > > > >> _______________________________________________ >> > > > > >> > > > > >> enlightenment-devel mailing list >> > > > > >> > > > > >> enlightenment-devel@lists.sourceforge.net >> > > > > >> > > > > >> >> > > > > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> > > > > >> >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > -- >> > > > > >> > > > > > ~Jeff Hoogland <http://jeffhoogland.com/> >> > > > > >> > > > > > My Projects on GitHub < >> https://github.com/JeffHoogland> >> > > > > >> > > > > > >> > > > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > >> > > > > ~Jeff Hoogland <http://jeffhoogland.com/> >> > > > > >> > > > > My Projects on GitHub <https://github.com/JeffHoogland >> > >> > > > > >> > > > > >> > > > > >> > > > >> > > > > >> > >> > > > > >> >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > >> > > > > _______________________________________________ >> > > > > >> > > > > enlightenment-devel mailing list >> > > > > >> > > > > enlightenment-devel@lists.sourceforge.net >> > > > > >> > > > > >> > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> > > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > > > -- >> > > > > >> > > > ------------- Codito, ergo sum - "I code, therefore I am" >> > > > > >> > -------------- >> > > > > >> > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > > > >> > > > > >> > >> > > > > >> >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > >> > > > _______________________________________________ >> > > > > >> > > > enlightenment-devel mailing list >> > > > > >> > > > enlightenment-devel@lists.sourceforge.net >> > > > > >> > > > >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> > > > >> > > > > >> > > >> > > > > >> > >> > > > > >> >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > >> > > _______________________________________________ >> > > > > >> > > enlightenment-devel mailing list >> > > > > >> > > enlightenment-devel@lists.sourceforge.net >> > > > > >> > > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> > > >> > > > > >> > >> > > > > >> > >> > > > > >> > -- >> > > > > >> > ------------- Codito, ergo sum - "I code, therefore I am" >> > > > > -------------- >> > > > > >> > The Rasterman (Carsten Haitzler) ras...@rasterman.com >> > > > > >> > >> > > > > >> > >> > > > > >> >> > > > > >> >> > > > > >> -- >> > > > > >> ~Jeff Hoogland <http://jeffhoogland.com/> >> > > > > >> My Projects on GitHub <https://github.com/JeffHoogland> >> > > > > >> >> > > > > >> >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > >> _______________________________________________ >> > > > > >> enlightenment-devel mailing list >> > > > > >> enlightenment-devel@lists.sourceforge.net >> > > > > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> >> > > > > > >> > > > > > >> > > > > >> > > > > >> > > >> ------------------------------------------------------------------------------ >> > > > > _______________________________________________ >> > > > > enlightenment-devel mailing list >> > > > > enlightenment-devel@lists.sourceforge.net >> > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > > > >> > > > >> > > >> ------------------------------------------------------------------------------ >> > > > _______________________________________________ >> > > > enlightenment-devel mailing list >> > > > enlightenment-devel@lists.sourceforge.net >> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> ------------------------------------------------------------------------------ >> > > _______________________________________________ >> > > enlightenment-devel mailing list >> > > enlightenment-devel@lists.sourceforge.net >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> > >> > >> > -- >> > ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> > The Rasterman (Carsten Haitzler) ras...@rasterman.com >> > >> > >> > >> ------------------------------------------------------------------------------ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > enlightenment-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ras...@rasterman.com >> >> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
