I see that you have
stealth-reverted 6ce353fced4471a649661a3e433c4d9bd509e203 with this commit.
Furthermore, setting "still" as a visibility effect is not valid with the
default theme.

It would be helpful if you could provide more constructive feedback on this
E20 feature than "animation was rather horrible. fix."; I have received a
number of positive comments from others on these effects, so perhaps they
are not functioning correctly on your system.

On Wed, Oct 7, 2015 at 6:55 AM Carsten Haitzler <[email protected]>
wrote:

> raster pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=d99869fed2e71613e73863e1e343909c97945819
>
> commit d99869fed2e71613e73863e1e343909c97945819
> Author: Carsten Haitzler (Rasterman) <[email protected]>
> Date:   Wed Oct 7 19:54:21 2015 +0900
>
>     e comp - default config was rather broken - fix
>
>     default config didnt select menu style shadow - was selecting
>     vertical/still which meant animation was rather horrible. fix.
> ---
>  src/bin/e_comp_cfdata.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/bin/e_comp_cfdata.c b/src/bin/e_comp_cfdata.c
> index d813937..91570fa 100644
> --- a/src/bin/e_comp_cfdata.c
> +++ b/src/bin/e_comp_cfdata.c
> @@ -152,8 +152,8 @@ e_comp_cfdata_config_new(void)
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
>     mat->primary_type = E_WINDOW_TYPE_DROPDOWN_MENU;
> -   mat->shadow_style = eina_stringshare_add("still");
> -   mat->visibility_effect = eina_stringshare_add("visibility/vertical");
> +   mat->shadow_style = eina_stringshare_add("menu");
> +   mat->visibility_effect = eina_stringshare_add("still");
>
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
> @@ -163,8 +163,8 @@ e_comp_cfdata_config_new(void)
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
>     mat->primary_type = E_WINDOW_TYPE_COMBO;
> -   mat->shadow_style = eina_stringshare_add("still");
> -   mat->visibility_effect = eina_stringshare_add("visibility/vertical");
> +   mat->shadow_style = eina_stringshare_add("menu");
> +   mat->visibility_effect = eina_stringshare_add("still");
>
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
> @@ -174,8 +174,8 @@ e_comp_cfdata_config_new(void)
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
>     mat->primary_type = E_WINDOW_TYPE_MENU;
> -   mat->shadow_style = eina_stringshare_add("still");
> -   mat->visibility_effect = eina_stringshare_add("visibility/vertical");
> +   mat->shadow_style = eina_stringshare_add("menu");
> +   mat->visibility_effect = eina_stringshare_add("still");
>
>     mat = E_NEW(E_Comp_Match, 1);
>     cfg->match.overrides = eina_list_append(cfg->match.overrides, mat);
>
> --
>
>
>
------------------------------------------------------------------------------
Full-scale, agent-less Infrastructure Monitoring from a single dashboard
Integrate with 40+ ManageEngine ITSM Solutions for complete visibility
Physical-Virtual-Cloud Infrastructure monitoring from one console
Real user monitoring with APM Insights and performance trend reports 
Learn More http://pubads.g.doubleclick.net/gampad/clk?id=247754911&iu=/4140
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to