On Thu, 08 Oct 2015 15:23:48 +0000 Mike Blumenkrantz <[email protected]> said:
> On Wed, Oct 7, 2015 at 10:59 PM Carsten Haitzler <[email protected]> > wrote: > > > On Wed, 07 Oct 2015 16:37:37 +0000 Mike Blumenkrantz > > <[email protected]> said: > > > > > I see that you have > > > stealth-reverted 6ce353fced4471a649661a3e433c4d9bd509e203 with this > > commit. > > > Furthermore, setting "still" as a visibility effect is not valid with the > > > default theme. > > > > > > It would be helpful if you could provide more constructive feedback on > > this > > > E20 feature than "animation was rather horrible. fix."; I have received a > > > number of positive comments from others on these effects, so perhaps they > > > are not functioning correctly on your system. > > > > i'd have to take a video of the menus going > > > > +-----+ > > > > +-----+ > > |Men | > > > > +-----+ > > |Men | > > |You | > > > > +-----+ > > |Men | > > |You | > > |Too | > > > > +-----+ > > |Men | > > |You | > > |Too | > > +-----+ > > > > and doing it fairly slowly. app menus (dropdowns etc.) (they looked > > different to > > e menus when they appeared. not same anim or look at all. the dropshadow > > was > > clipped when using that vertical animation with menu style and they chose > > still instead of the menu shadow style. in fact dropshadow was missing > > entirely as a result. it looked totally wrong for a bit i went "wtf? what > > bug > > just got added to evas?". i then realized it was the config + style. > > > > i didn't notice for ages because my config had it "correct". tho i had to > > guess. when i got home i found a working config and fixed that up this > > morning. > > > > i looked at the code and went "oh... crap - that explains it". > > > > so 1. that commit uses the wrong style - still misses a shadow entirely. > > and > > the actual "visibility/vertical" effect is just broken. it slides open the > > menu > > as if clipped and the clipper expands. i'm putting it back to defaults > > where it > > was and looked decent. > > > > It's strange that you're seeing the shadow as clipped; it shows up normally > here. The initial commit of the visibility effects did indeed have this > issue, but a fix for it was pushed a couple days later. As for the > rendering speed, this is also bizarre since they have the exact same timing > as all other effects: 0.2 seconds. This video, posted to the release blog > some months ago, shows them functioning normally in Firefox: > https://www.youtube.com/watch?v=hIVdd0Z2K00&hd=1 > > I've also provisioned a number of installs since the original config > changes went in and have not had any issues similar to what you experienced. that's what i saw - the cfdata would have kicked in and reset config. i eet -d'd my config and it matched whats in the cfdata file. i have now put it back to where it was originally and it works properly now. :) > > i think the visibliy effects add too much complexity. that's what the > > shadow > > styles are for. all this does it make each style become more complex as it > > has > > to now implement signals to switch animation mode and most likely to do > > this > > right now needs a bunch of embryo to do the logic. > > > > I think this is an improvement over the shadow style, and in the future I'd > prefer to move visibility/focus effects to this place entirely. At present, > the "shadow" style which was originally intended to just provide a > dropshadow and some fading now requires a number of clippers for color > classes and fading, not to mention lots of signal handling (which is still > the primary source of reported bugs when using third party themes), and > this still has edje bugs which are triggered any time a color class is set. > Furthermore, the comp frame needs embryo now in order to handle focus with > CSD so that's a moot point. Having a clear separation between > "shadow/visual object" and "effects" object seems like it should be more > intuitive when working on themes. CSD changes things a lot. but having to expand the signal handling even more makes things more complex. > > > On Wed, Oct 7, 2015 at 6:55 AM Carsten Haitzler <[email protected]> > > > wrote: > > > > > > > raster pushed a commit to branch master. > > > > > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=d99869fed2e71613e73863e1e343909c97945819 > > > > > > > > commit d99869fed2e71613e73863e1e343909c97945819 > > > > Author: Carsten Haitzler (Rasterman) <[email protected]> > > > > Date: Wed Oct 7 19:54:21 2015 +0900 > > > > > > > > e comp - default config was rather broken - fix > > > > > > > > default config didnt select menu style shadow - was selecting > > > > vertical/still which meant animation was rather horrible. fix. > > > > --- > > > > src/bin/e_comp_cfdata.c | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/src/bin/e_comp_cfdata.c b/src/bin/e_comp_cfdata.c > > > > index d813937..91570fa 100644 > > > > --- a/src/bin/e_comp_cfdata.c > > > > +++ b/src/bin/e_comp_cfdata.c > > > > @@ -152,8 +152,8 @@ e_comp_cfdata_config_new(void) > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > mat->primary_type = E_WINDOW_TYPE_DROPDOWN_MENU; > > > > - mat->shadow_style = eina_stringshare_add("still"); > > > > - mat->visibility_effect = > > eina_stringshare_add("visibility/vertical"); > > > > + mat->shadow_style = eina_stringshare_add("menu"); > > > > + mat->visibility_effect = eina_stringshare_add("still"); > > > > > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > @@ -163,8 +163,8 @@ e_comp_cfdata_config_new(void) > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > mat->primary_type = E_WINDOW_TYPE_COMBO; > > > > - mat->shadow_style = eina_stringshare_add("still"); > > > > - mat->visibility_effect = > > eina_stringshare_add("visibility/vertical"); > > > > + mat->shadow_style = eina_stringshare_add("menu"); > > > > + mat->visibility_effect = eina_stringshare_add("still"); > > > > > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > @@ -174,8 +174,8 @@ e_comp_cfdata_config_new(void) > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > mat->primary_type = E_WINDOW_TYPE_MENU; > > > > - mat->shadow_style = eina_stringshare_add("still"); > > > > - mat->visibility_effect = > > eina_stringshare_add("visibility/vertical"); > > > > + mat->shadow_style = eina_stringshare_add("menu"); > > > > + mat->visibility_effect = eina_stringshare_add("still"); > > > > > > > > mat = E_NEW(E_Comp_Match, 1); > > > > cfg->match.overrides = eina_list_append(cfg->match.overrides, mat); > > > > > > > > -- > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Full-scale, agent-less Infrastructure Monitoring from a single dashboard > > > Integrate with 40+ ManageEngine ITSM Solutions for complete visibility > > > Physical-Virtual-Cloud Infrastructure monitoring from one console > > > Real user monitoring with APM Insights and performance trend reports > > > Learn More > > http://pubads.g.doubleclick.net/gampad/clk?id=247754911&iu=/4140 > > > _______________________________________________ > > > enlightenment-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
