As you said in the commit message, and just to correct terminology:

You are not "forcing empty function parameters", it's just how the 
syntax works.

int foo();     // Unspecified parameters
int foo(void); // No parameters

So probably it should be better described as "correct declaration of 
function with no parameters".

I'm being a bit pedantic, but it's just that obviously someone (whoever 
wrote that code) doesn't know the difference, so it's important to make 
it crystal clear for current and future contributors.

--
Tom.

On 26/11/15 16:36, Stefan Schmidt wrote:
> stefan pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=e683a53f926dbfefb11a35f277eae8ca0176f2fd
>
> commit e683a53f926dbfefb11a35f277eae8ca0176f2fd
> Author: Stefan Schmidt <[email protected]>
> Date:   Thu Nov 26 17:20:14 2015 +0100
>
>      edje_decc: use void to force empty function parameters
>
>      We have to use void in a function declaration if we want no function
>      parameters. Using just empty parenthesis means the function takes an
>      unspecified number of parameters.
>
>      We had it correct for most declarations and this series fixes it for
>      the rest.
> ---
>   src/bin/edje/edje_decc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/bin/edje/edje_decc.c b/src/bin/edje/edje_decc.c
> index 5eeb7ef..2f5fe96 100644
> --- a/src/bin/edje/edje_decc.c
> +++ b/src/bin/edje/edje_decc.c
> @@ -35,8 +35,8 @@ int new_dir = 1;
>
>   int        decomp(void);
>   void       output(void);
> -static int compiler_cmd_is_sane();
> -static int root_filename_is_sane();
> +static int compiler_cmd_is_sane(void);
> +static int root_filename_is_sane(void);
>
>
>   static void
>


------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to