If it doesn't cause any critical side effects/compatibility issues, I can't see any reasons to keep it in.
No one expects window layer value is 50. But I'd rather ask why 50? why it should have layer 50? Specifically, evas_object_layer_set() API has been exposed, which means the layer setting is up to users, even window object can be dealt with the API by users. Additionally, window object was special one so it have been deal with event stuff differently. Regards, Hermet -----Original Message----- From: "Amitesh Singh"<singh.amit...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: "Carsten Haitzler"<ras...@rasterman.com>; Sent: 2015-12-25 (금) 16:05:50 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: Remove unnecessary layer set for elm_win. Hello On Dec 18, 2015 3:54 PM, "Jaehyun Cho" <jae_hyun....@samsung.com> wrote: > > jaehyun pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=a9be1d488daf74d11181909fb6c454991272fe1e > > commit a9be1d488daf74d11181909fb6c454991272fe1e > Author: Jaehyun Cho <jae_hyun....@samsung.com> > Date: Fri Dec 18 19:18:51 2015 +0900 > > elm_win: Remove unnecessary layer set for elm_win. > --- > src/lib/elm_win.c 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c > index b1a05ae..f509f95 100644 > --- a/src/lib/elm_win.c > +++ b/src/lib/elm_win.c > @@ -3830,7 +3830,6 @@ _elm_win_finalize_internal(Eo *obj, Elm_Win_Data *sd, const char *name, Elm_Win_ > evas_object_color_set(obj, 0, 0, 0, 0); > evas_object_move(obj, 0, 0); > evas_object_resize(obj, 1, 1); > - evas_object_layer_set(obj, 50); I wonder why it was removed. As far as I know, elm win is a fake ecore evas object. Basically it's just a wrapper of ecore evas and since elm win does not contain any object so I think it's better to put it at layer 50. After this change, there could be a case when it does not receive any events as it might go at lowest at layer 0. This could result into some side effects. Please consider this. > evas_object_pass_events_set(obj, EINA_TRUE); > > if (type == ELM_WIN_INLINED_IMAGE) > > -- > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
