On 22 January 2016 at 17:49, Stefan Schmidt <ste...@osg.samsung.com> wrote:

> Hello.
>
> On 22/01/16 07:52, Jean-Philippe ANDRÉ wrote:
> > jpeg pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/efl.git/commit/?id=7336b7ed9f9ea7c5f8b1e7ff46529ec8bf1845e4
> >
> > commit 7336b7ed9f9ea7c5f8b1e7ff46529ec8bf1845e4
> > Author: Jean-Philippe Andre <jp.an...@samsung.com>
> > Date:   Fri Jan 22 15:23:15 2016 +0900
> >
> >      Evas filters: Re-enable transform test case, remove dead code
> >
> >      Now that transform is fixed, this should be reenabled.
> > ---
> >   src/tests/evas/evas_test_filters.c | 23 -----------------------
> >   1 file changed, 23 deletions(-)
> >
> > diff --git a/src/tests/evas/evas_test_filters.c
> b/src/tests/evas/evas_test_filters.c
> > index 43232e3..5301af8 100644
> > --- a/src/tests/evas/evas_test_filters.c
> > +++ b/src/tests/evas/evas_test_filters.c
> > @@ -188,16 +188,6 @@ START_TEST(evas_filter_parser)
> >         "White"
> >      };
> >
> > -#if 0
> > -   // New color class defaults to black
> > -   static const char *colors_bad[] = {
> > -      "newcolor",
> > -      "ABC",
> > -      "#ZZZ",
> > -      "#-10"
> > -   };
> > -#endif
> > -
> >      for (size_t c = 0; c < sizeof(colors) / sizeof(colors[0]); c++)
> >        {
> >           char buf[64];
> > @@ -205,17 +195,6 @@ START_TEST(evas_filter_parser)
> >           CHKGOOD(buf);
> >        }
> >
> > -#if 0
> > -   fprintf(stderr, "Evas filters tests: start invalid cases. Ignore the
> following ERRs.\n");
> > -   for (size_t c = 0; c < sizeof(colors_bad) / sizeof(colors_bad[0]);
> c++)
> > -     {
> > -        char buf[64];
> > -        sprintf(buf, "blend { color = '%s' }", colors_bad[c]);
> > -        CHKBAAD(buf);
> > -     }
> > -   fprintf(stderr, "Evas filters tests: end of invalid cases.\n");
> > -#endif
> > -
> >      // fillmodes are parsed when converting from instructions to
> commands
> >   }
> >   END_TEST
> > @@ -277,11 +256,9 @@ static struct Filter_Test_Case _test_cases[] = {
> >      { 7, 7, 7, 7, "a = buffer ({ 'rgba' }) b = buffer ({ 'rgba' })
> blend ({ dst = b, color = '#330' }) blend ({ dst = a }) displace ({ map =
> b, src = a, intensity = 7, flags = 'smooth_stretch' })", NULL },
> >
> >      /* FIXME Fix transform filter!!! FIXME */
>
> The FIXME can also get removed here as transform filters are fixed?
>

Good point :)


>
> regards
> Stefan Schmidt
>
> > -#if 0
> >      { 0, 0, 0, 40, "a = buffer ({ 'alpha' }) transform ({ a, 'vflip',
> oy = 20 }) blend ({ src = a })", NULL },
> >      { 0, 0, 40, 0, "a = buffer ({ 'alpha' }) transform ({ a, 'vflip',
> oy = -20 }) blend ({ src = a })", NULL },
> >      { 0, 0, 0, 40, "a = buffer ({ 'alpha' }) blend ({ dst = a })
> transform ({ a, 'vflip', oy = 20, src = a }) blend ({ src = a })", NULL },
> > -#endif
> >
> >      // Filter combos. TODO: Add some more tricky cases : })
> >      { 3, 5, 7, 11, "blend ({ ox = -3, oy = 11 })  blend ({ ox = 5, oy =
> -7 })", NULL },
> >
>
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Jean-Philippe André
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to