Hello. On 06/01/16 19:38, Cedric BAIL wrote: > Hello, > > On Wed, Jan 6, 2016 at 7:52 AM, Stefan Schmidt <[email protected]> wrote: >> On 05/01/16 17:05, Tom Hacohen wrote: >>> Here again, the new EFL + Elementary ABI reports. >>> >>> As usual: >>> https://devs.enlightenment.org/~tasn/abi/ >> My review for EFL. Happy about every other review or comment here. >> >> Ignoring the unstable EO APIs as well as ector which is marked as >> unstable we have still a big number of new APIs: >> >> Ecore_Evas.h >> ecore_evas_cocoa_window_get ( Ecore_Evas const* ee ) >> ecore_evas_wayland_window_get2 ( Ecore_Evas const* ee ) > get2 ? Is it something we usually do ? Why do we need a get2 ? I mean, > we are in C switching to return a void * is not an ABI break and it > would not create a new function (Arguably all this window_get could > really be just the same function).
Are you fine with the renaming Chris did? >> Efl_Model_Common.h >> efl_model_error_notify ( Efl_Model_Base* model ) >> efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int >> count ) >> efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum >> Efl_Model_Load_Status status ) >> efl_model_property_changed_notify ( Efl_Model_Base* model, char const* >> property ) >> efl_model_property_invalidated_notify ( Efl_Model_Base* model, char >> const* property ) >> efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc ) >> efl_model_value_struct_description_new ( unsigned int member_count, >> Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data ) > This should still be under BETA flag, isn't that the case ? To me the > header is completely protected by the BETA flag. > Hmm, do you mean because it is included behind a #ifdef EFL_BETA_API_SUPPORT in Efl.h? The Efl_Model_Common.h has no BETA_API guards at all and it is shipped which means anyone can include this without having to define the BETA_API in their app. I think some guards inside Efl_Model_Common.h are also needed. regards Stefan Schmidt ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
