my point is not EINA_UNUSED nor animator. As you mentioned, event_info is used for sometimes.
How many scenarios will use those event_info and desc in the future? Im worring about our code is getting more long and dirty because of this. See our evas_object_smart_callback and evas_object_event_callback function prototypes. I'm curious if we could provide simpler version. -----Original Message----- From: "Tom Hacohen"<[email protected]> To: <[email protected]>; Cc: Sent: 2016-02-04 (목) 23:30:07 Subject: Re: [E-devel] EFL interface change - Animator On 04/02/16 14:13, Hermet Park wrote: > This may be an annother topic question, > > _elm_panel_anim_cb(void *data, > Eo *o EINA_UNUSED, const > Eo_Event_Description *desc EINA_UNUSED, > void *event_info EINA_UNUSED) > > Why should people struggle with these unused desc, event_info stuff? > As you know, we unecessarily have typed annoying "event_info" before. > > How about if we provide this kind of simpler version ? > eo_clean_event_callback_add(EFL_CORE_ANIMATOR_EVENT_ANIMATOR_TICK, > _elm_panel_anim_cb, obj)); > > _elm_panel_anim_cb(void *data, Eo *o) > { > ... > } Because event_info is sometimes used in callbacks. It's specifically used in animators (update region). Desc may be used too, and this is the only way to get it. If you don't care about unused parameters, don't use the compilation flag, and then you won't need to use EINA_UNUSED. We care about those in the EFL, so we use the flag and have to do it. These parameters are correct and essential. -- Tom. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
