On 24/02/16 10:35, Tom Hacohen wrote: > On 04/02/16 15:58, [email protected] wrote: >> Hi, >> >> On Thu, Feb 04, 2016 at 03:48:17PM +0000, Tom Hacohen wrote: >>> On 04/02/16 15:18, Hermet Park wrote: >>>> my point is not EINA_UNUSED nor animator. >>>> >>>> As you mentioned, event_info is used for sometimes. >>>> >>>> How many scenarios will use those event_info and desc in the future? >>>> Im worring about our code is getting more long and dirty because of >>>> this. >>>> See our evas_object_smart_callback and evas_object_event_callback >>>> function prototypes. >>>> >>>> I'm curious if we could provide simpler version. >>> >>> event_info: a lot. >>> desc: debatable, though maybe bindings will make good use of it to ease >>> attaching to callbacks. We are not entirely sure, but we wanted it >>> because we had some cases in mind (that I don't remember at the moment) >>> where we thought this could prove useful. >>> >>> smart callbacks have event_info, and it's useful, so I don't see your >>> point. >> >> Why not having something like >> >> _event_cb(void *data, Event *ev) {...} >> >> with >> >> typedef struct { >> Eo *obj >> Eo_Event_Description2 *desc >> void *event_info >> } Event; >> >> I wouldnt put *data in this structure since its more often used than >> obj/desc/event_info. >> >> Greetings bu5hm4n > > Sorry for the long delay. > > Since there has been no objections, and I managed to convince Carsten, > we are going to go forward with this suggestion almost the way you > suggested it. The only different is that data is going to be the second > parameter. :) > > I plan on working on it when I'm back from Korea (next week). > > Thanks again for the good idea. :P
OK, following comments by bu5hm4n data is going to be first. -- Tom. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
