Hello,
I fix the table items name and signals from them. But
not pushed now.
I have one problem with the signal source from item.
Cedric, this code you wrote 5 years ago. I understand
that chance to remember it is very small. Can you explaine
what a magic number '12' you use in commit c54cc9508.
This magic number is break emited 'source'. For example
a table item name 'cell{1,10}' is not passed.
On 04/21/16 14:06, Viacheslav Reutskiy wrote:
> Shuhrat, thank you.
>
> Now I know why it revert was happened. But it wrong way.
> Need update the elemines code: set to table items name
> and update the source string from 'board[%i,%i]' to
> 'board[item_name{%i,%i}]'.
>
>
>
>
>
> On 04/21/16 12:43, Shuhrat Dehkanov wrote:
>>>
>>> Now I fix the elemines
>>
>> You may want to take a look on https://phab.enlightenment.org/D3820On
>> Thu, Apr 21, 2016 at 4:21 PM, Viacheslav Reutskiy <[email protected]
>>>
>>> wrote:
>>>
>>> Cedric, you broke the all edje_edit_part_item_* API's, in case when
>>> part items have not name. This patch was added for unify the names
>>> in the EDJ. Now I fix the elemines. Also this commit break Eflete.
>>> On 04/19/16 21:57, Cedric BAIL wrote:
>>>>
>>>> cedric pushed a commit to branch master.
>>>
>>> http://git.enlightenment.org/core/efl.git/commit/?id=7c743b675401ecd268e946bdccdbdafc28f8d979
>>>>
>>>> commit 7c743b675401ecd268e946bdccdbdafc28f8d979 Author: Cedric BAIL
>>>> <[email protected]>Date: Tue Apr 19 11:56:17 2016 -0700 Revert
>>>> "Set the name for table, box items" This reverts commit
>>>> 6f7608befd006f8076d237bee5d17c9e9e1e09ac. Item in table and box do
>>>> not need names as they have an index. This is breaking ABI for edje
>>>> application that rely on getting the index properly when a signal
>>>> is emitted. To be precise, this did break elemines. ---
>>>> src/bin/edje/edje_cc_out.c | 7 ------- 1 file changed, 7
>>>> deletions(-) diff --git a/src/bin/edje/edje_cc_out.c
>>>> b/src/bin/edje/edje_cc_out.c index 03cf57e..3bdfe7e 100644 ---
>>>> a/src/bin/edje/edje_cc_out.c +++ b/src/bin/edje/edje_cc_out.c @@
>>>> -518,16 +518,9 @@ static void
>>>> check_packed_items(Edje_Part_Collection *pc, Edje_Part *ep, Eet_File
>>>
>>> *ef)
>>>>
>>>> { unsigned int i; - char *def_name; for (i = 0; i <
>>>> ep->items_count; ++i) { - if (!ep->items[i]->name) - { - def_name =
>>>> alloca(strlen("item_") +
>>>
>>> strlen("0xFFFFFFFFFFFFFFFF") + 1);
>>>>
>>>> - sprintf(def_name, "item_%p", def_name); - ep->items[i]->name =
>>>> strdup(def_name); - } if (ep->items[i]->type ==
>>>> EDJE_PART_TYPE_GROUP &&
>>>
>>> !ep->items[i]->source)
>>>>
>>>> error_and_abort(ef, "Collection %i: missing source on packed
>>>
>>> item "
>>>>
>>>> "of type GROUP in part \"%s\"",
>>>
>>> -- Viacheslav Reutskiy (rimmed)
>>> ------------------------------------------------------------------------------
>>>
>>> Find and fix application performance issues faster with Applications
>>> Manager Applications Manager provides deep performance insights into
>>> multiple tiers of your business applications. It resolves
>>> application problems quickly and reduces your MTTR. Get your free
>>> trial!
>>> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z_______________________________________________
>>>
>>> enlightenment-devel mailing list
>>> [email protected]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>> ------------------------------------------------------------------------------
>>
>> Find and fix application performance issues faster with Applications
>> Manager Applications Manager provides deep performance insights into
>> multiple tiers of your business applications. It resolves application
>> problems quickly and reduces your MTTR. Get your free trial!
>> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z_______________________________________________
>>
>> enlightenment-devel mailing list
>> [email protected]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> -- Viacheslav Reutskiy (rimmed)
-- Viacheslav Reutskiy (rimmed)
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
