On 04/22/16 08:45, Cedric BAIL wrote:
> On Thu, Apr 21, 2016 at 9:50 PM, Viacheslav Reutskiy
> <[email protected]> wrote:
>> On 04/22/16 00:40, Cedric BAIL wrote:
>>> On Thu, Apr 21, 2016 at 6:20 AM, Viacheslav Reutskiy
>>> <[email protected]> wrote:
>>>> I fix the table items name and signals from them. But not pushed now.
>>> Good, because I have serious doubt you can fix it. You should rely
>>> on index.
>> Yes, it's fixed. I will push it to review on phab.
> Ok, will look later on.
>>>> I have one problem with the signal source from item. Cedric, this
>>>> code you wrote 5 years ago. I understand that chance to remember it
>>>> is very small. Can you explaine what a magic number '12' you use in
>>>> commit c54cc9508. This magic number is break emited 'source'. For
>>>> example a table item name 'cell{1,10}' is not passed.
>>> Yes, if the item haven't any name, they have a name due to their
>>> index. In a box, the index is one dimension, one int, thus the
>>> length of it (from int to string) will always fit inside 12 bytes.
>>> That's where this 12 comes from. That's also how the unique name of
>>> that item is defined.
>> We have a problem with generated 'source' for table item. If the
>> string length is 10 - 'source' source has a value 'table_name[0]'.
>> For exaple, case from elemines: cell{2,10}. All items name, with name
>> lenght eqaul 10, will be replaced. In this case we have the behavior
>> as if it's box.
> Oh, interesting. Indeed, that need to be fixed. We should have 26 for
> the table case. Can you try by moving the length_index = 12 into the
> part->type == EDJE_PART_TYPE_BOX if and and add a length_index = 26 in
> the part->type == EDJE_PART_TYPE_TABLE ? This should solve the problem.
I think need to refuse to checkthe length_index, and check the part
type. It will solve this problem.
Somsing like:
<code>
if (pack_it->parent->part->type == EDJE_PART_TYPE_BOX)
length_parent += eina_convert_itoa(i, new_src + length_parent);
else
{
memcpy(new_src + length_parent, name, length_index - 2);
length_parent += length_index - 2;
}
</code>
>>>> On 04/21/16 14:06, Viacheslav Reutskiy wrote:
>>>>> Shuhrat, thank you. Now I know why it revert was happened. But it
>>>>> wrong way. Need update the elemines code: set to table items name
>>>>> and update the source string from 'board[%i,%i]' to
>>>>> 'board[item_name{%i,%i}]'.
>>> Just to be clearer on my earlier message. Signal are part of all
>>> theme ABI. The fact that I missed this commit and let it go for so
>>> long is bad. It has broken application which rely on annonymous item
>>> in table and box. Which is a suppored use case as you can see by
>>> looking at the code base, as they just get there name based on the
>>> index in the part they are in.
>> Ok, I will try to move the part item generation to edje edit.
About edje edit: I made the fast review of API, and see that have to
sense to redesign (or add new API) to use index. It can help to refuse
strcmp
usage. But need to investigate it.
> Thanks !
>
> Cedric
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications Manager
> Applications Manager provides deep performance insights into multiple tiers of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Viacheslav Reutskiy (rimmed)
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
