On Tue, Sep 20, 2016 at 5:51 AM, Jean-Philippe André <j...@videolan.org> wrote: > Hi Gustavo, > > On 14 September 2016 at 13:55, Gustavo Sverzut Barbieri <barbi...@gmail.com> > wrote: > >> HEADS UP -- BINDINGS: >> >> If you wish to expose the new "cancellable" property, or cope with >> naughty users or 3rd party deps that may call >> pthread_setcancelstate(PTHREAD_CANCEL_ENABLE), please register your >> cleanup functions with: >> >> EINA_THREAD_CLEANUP_PUSH(cb, ctx); // will call cb() on >> pthread_cancel()/ecore_thread_cancel()/eina_thread_cancel() >> call_user(); >> EINA_THREAD_CLEANUP_POP(EINA_TRUE); // will call cb() on clean exit >> >> If different functions are desired: >> >> EINA_THREAD_CLEANUP_PUSH(cb, ctx); // will call cb() on >> pthread_cancel()/ecore_thread_cancel()/eina_thread_cancel() >> call_user(); >> EINA_THREAD_CLEANUP_POP(EINA_FALSE); // will NOT call cb() on clean >> exit >> another_cb(ctx); >> >> This is recommended if you expose ecore_thread to your users. If you >> don't, then you do not need to do anything. > > > pthread_cancel did (does?) not exist on Android, by design choice. bionic > isn't posix in that regard. > One way or another, I remember that using cancel is actually quite hard, > because you need to be very careful about the cleanup. > > So I wonder if adding cancel like pthread here is the best choice? > Note that I understand the need and don't have any good alternative :)
Hi jpeg, thanks for letting me know. When we port to bionic we should then take one choice: - let the thread hang there for a while, the new code I'm doing based on this concept shouldn't break, it will just consume few more resources for a while. (== #ifdef) - use pthread_kill() with an unused signal and use a signal handler... this can be a full wrapper like the one in videolan.org, or just to generate EINTR like I proposed in my first discussion. -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (16) 99354-9890 ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
