[EGIT] [core/efl] master 02/03: elm_entry: Cursor disappears on calling select function in an empty entry.

[Shilpa Singh]

jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=442ab2bc67411ab98ddc83c2261c72a6bccf940b

commit 442ab2bc67411ab98ddc83c2261c72a6bccf940b
Author: Shilpa Singh <shilpa.si...@samsung.com>
Date:   Fri May 12 15:10:37 2017 +0900

    elm_entry: Cursor disappears on calling select function in an empty entry.
    
    Summary:
    Issue: Selection cannot happen on an empty entry, if selection functions
    are called on empty entry, cursor is hidden, even if entry is focused.
    Soln: Check for whether entry is empty or not before proceeding with 
selection.
    
    Test Plan:
    1. Call select_all, select_region_set on a focused entry
    2. You can observe cursor cannot be seen.
    
    Reviewers: jpeg
    
    Reviewed By: jpeg
    
    Subscribers: cedric, jpeg
    
    Differential Revision: https://phab.enlightenment.org/D4862
---
 src/lib/elementary/elm_entry.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_entry.c b/src/lib/elementary/elm_entry.c
index 46fd873..dba796a 100644
--- a/src/lib/elementary/elm_entry.c
+++ b/src/lib/elementary/elm_entry.c
@@ -4286,8 +4286,9 @@ _elm_entry_select_none(Eo *obj EINA_UNUSED, 
Elm_Entry_Data *sd)
 }
 
 EOLIAN static void
-_elm_entry_select_all(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd)
+_elm_entry_select_all(Eo *obj, Elm_Entry_Data *sd)
 {
+   if (elm_entry_is_empty(obj)) return;
    if ((sd->password)) return;
    if (sd->sel_mode)
      {
@@ -4301,8 +4302,9 @@ _elm_entry_select_all(Eo *obj EINA_UNUSED, Elm_Entry_Data 
*sd)
 }
 
 EOLIAN static void
-_elm_entry_select_region_set(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd, int 
start, int end)
+_elm_entry_select_region_set(Eo *obj, Elm_Entry_Data *sd, int start, int end)
 {
+   if (elm_entry_is_empty(obj)) return;
    if ((sd->password)) return;
    if (sd->sel_mode)
      {

--