jpeg pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=ef2f37cad13114d765b8a041e2aea222cdf08c30
commit ef2f37cad13114d765b8a041e2aea222cdf08c30
Author: JinYong Park <j4939.p...@samsung.com>
Date: Fri May 12 14:59:32 2017 +0900
popup: move "visible_set(FALSE)" before calling dismissed callback
Summary:
After hiding animation is finished, "dismissed" callback will be called.
It means popup's visible state is FALSE.
But if evas_object_show(popup) is called in it's custom dimssed callback
function,
popup's visible state is TRUE, so evas_object_show is canceled.
So visible_set(FALSE) is must done before call dimissed callback.
@fix
Reviewers: Hermet, herb, jpeg, cedric, singh.amitesh, raster
Reviewed By: jpeg
Subscribers: woohyun
Differential Revision: https://phab.enlightenment.org/D4869
---
src/lib/elementary/elc_popup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/elc_popup.c b/src/lib/elementary/elc_popup.c
index a24c1c0..dcb78a3 100644
--- a/src/lib/elementary/elc_popup.c
+++ b/src/lib/elementary/elc_popup.c
@@ -118,8 +118,8 @@ _timeout_cb(void *data, const Efl_Event *event EINA_UNUSED)
static void
_hide_effect_finished_cb(void *data, const Efl_Event *event EINA_UNUSED)
{
- efl_event_callback_legacy_call(data, ELM_POPUP_EVENT_DISMISSED, NULL);
efl_gfx_visible_set(data, EINA_FALSE);
+ efl_event_callback_legacy_call(data, ELM_POPUP_EVENT_DISMISSED, NULL);
}
--
