I apologize, I should have been more clear: I was questioning why this is making a new window to grab instead of using the existing e_comp_(un)grab_input() API.
On Mon, Jul 10, 2017 at 7:42 PM Carsten Haitzler <[email protected]> wrote: > On Mon, 10 Jul 2017 18:37:40 +0000 Mike Blumenkrantz > <[email protected]> said: > > > I did some cleanup on this to prevent it from permanently breaking input, > > which led me to wonder why you need to do a window grab here in any > case? I > > don't see anything in the commit log related to it and there was nothing > > obvious in the code. > > you have to grab otherwise x controls the pointer based on what the > pointer is > over. e.g. it's over xterm the pointer remains a visible I bar > irrespective of > what we do. without grabbing during this period (before the screen is > forcibly > dpms turned off) the screen fades out but the cursor remains visible during > this time (unlike wayland). the grab gives us control over it and then > allows > us to hide it along with the rest of the screen. remove the grab and watch > this > break and not work when the mouse is over a window that has its own custom > cursor. it's a necessary detail for it to simply work at all in all > circumstances (or all that we can manage - if a client already has it > grabbed... well... we're in trouble - yes. there was some work to add an > x11 > extension protocol to break grabs from memory). > > oh yeah... the backlight doesn't dim. can't control it. thus why you see > the > pointer staring at you clear as daylight, so i fixed it... > > > On Sun, Jul 9, 2017 at 10:02 PM Carsten Haitzler <[email protected]> > > wrote: > > > > > raster pushed a commit to branch master. > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=d0c5fb465b699ebe7556c61e14f12c9882620175 > > > > > > commit d0c5fb465b699ebe7556c61e14f12c9882620175 > > > Author: Carsten Haitzler (Rasterman) <[email protected]> > > > Date: Mon Jul 10 09:08:25 2017 +0900 > > > > > > support connected standby (non-s3 sleep/freeze) that new lpatops > sport > > > > > > this requires we have to force dpms on to reduce power. to avoid > > > glitches with the pointer staying around in x we need to support > > > suspending it too so it hides cleanly like the screen dims or > undims. > > > also use the new powersave freeze mode to do this. > > > > > > note that i've tested this on s3 supporting laptops and non-s3 and > it > > > "works for me". it may require more testing and work. there is > more to > > > power saving than just this as well but for now that's out of > scope as > > > you have to mess with linux device autosuspend timeouts and a bunch > > > more (wowlan ... blahblah). > > > > > > i need to find the source of the intermittent wakeups too in e. > there > > > is a long lived timeout (8-ish seconds?) but more specifically e > keeps > > > waking up from fd's and then reading /sys stuff about battery - > some > > > event is causing us to do this... maybe to suspend this or make > > > battery checking very rare when in freeze mode (or screen off) etc. > > > > > > so this fixes some glitches as well as supports a new way of > sleeping > > > "alive" when hardware literally doesnt support normal s3 sleep... > so > > > kind of a fix with a feature. > > > > > > > > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
