On Tue, 11 Jul 2017 19:21:05 +0000 Mike Blumenkrantz <[email protected]> said:
> I've gone through a few drafts of this reply, but all that's worth saying > is I'm disappointed that you felt the need to: > * disregard a serious bug report both here on the list and in irc what bug report where? you made a comment about "permanently breaking input" but i put that down to hyperbole as absolutely no other information was provided and it worked in every single case and machine i tried. you did totally break the glitch fix (this i consider a visual glitch where the pointer is still visible glaringly bright as day but the rest of the screen fades out) and it may as well have been just removed at that point as now the pointer animated in reverse (from hidden to shown) and then still stayed visible on fade out and did nothing on fade in at all. > * revert my patch which avoided this issue in favor of your new feature see my log. your patch then went to break it. i tested. you seemingly did not. > * continue to disregard the possibility of such an issue in your reply you provide no bug report i can discern other than the above. > I'm not interested in turning this into a thread of long essays as my > typing time is limited, so let's leave it at that. i'm disappointed that you altered code i had tested and made specifically work across multiple machines with varying hardware, suspend, resume, hibernate, unhibernate, no suspend at all (no s3) and also screenblank. i did miss having desklock up at the time, found and fixed that case without any input or help or information from you. if that was your issue then state it. you certainly did not and it does not permanently break all input - if you restart he (send a HUP signal) it fixes it and you can log in, but then you change it all to be totally broken seemingly without a single test because the very first thing i saw was "well that broke". so i moved it back to where it was before you broke it as i have no information as to there being any bug or what it might at all be. > On Mon, Jul 10, 2017 at 10:17 PM Carsten Haitzler <[email protected]> > wrote: > > > On Mon, 10 Jul 2017 18:37:40 +0000 Mike Blumenkrantz > > <[email protected]> said: > > > > as i thought. your cleanup broke it pretty much entirely. :( reverted it > > back > > to its working state. :) > > > > it doesn't permanently break input... it grabs temporarily just for the > > animation until screen is off and thus cursor not visible anymore. > > > > > I did some cleanup on this to prevent it from permanently breaking input, > > > which led me to wonder why you need to do a window grab here in any > > case? I > > > don't see anything in the commit log related to it and there was nothing > > > obvious in the code. > > > > > > On Sun, Jul 9, 2017 at 10:02 PM Carsten Haitzler <[email protected]> > > > wrote: > > > > > > > raster pushed a commit to branch master. > > > > > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=d0c5fb465b699ebe7556c61e14f12c9882620175 > > > > > > > > commit d0c5fb465b699ebe7556c61e14f12c9882620175 > > > > Author: Carsten Haitzler (Rasterman) <[email protected]> > > > > Date: Mon Jul 10 09:08:25 2017 +0900 > > > > > > > > support connected standby (non-s3 sleep/freeze) that new lpatops > > sport > > > > > > > > this requires we have to force dpms on to reduce power. to avoid > > > > glitches with the pointer staying around in x we need to support > > > > suspending it too so it hides cleanly like the screen dims or > > undims. > > > > also use the new powersave freeze mode to do this. > > > > > > > > note that i've tested this on s3 supporting laptops and non-s3 and > > it > > > > "works for me". it may require more testing and work. there is > > more to > > > > power saving than just this as well but for now that's out of > > scope as > > > > you have to mess with linux device autosuspend timeouts and a bunch > > > > more (wowlan ... blahblah). > > > > > > > > i need to find the source of the intermittent wakeups too in e. > > there > > > > is a long lived timeout (8-ish seconds?) but more specifically e > > keeps > > > > waking up from fd's and then reading /sys stuff about battery - > > some > > > > event is causing us to do this... maybe to suspend this or make > > > > battery checking very rare when in freeze mode (or screen off) etc. > > > > > > > > so this fixes some glitches as well as supports a new way of > > sleeping > > > > "alive" when hardware literally doesnt support normal s3 sleep... > > so > > > > kind of a fix with a feature. > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > > > enlightenment-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
