On Sat, Mar 15, 2014 at 02:10:17PM -0400, Jesper Pedersen wrote: > On 01/04/2014 12:08 PM, Jesper Pedersen wrote: > >Here is an initial patch for being able to select the background and > >highlight color for the images. > > > >The use-case is that you want an "opposite" background color against > >what you are shooting, e.g. white background when shooting using a black > >backdrop. > > > >However, there are a couple of problems with the patch as is. > > > >1) Images appear and disappear from the image browser when clicking around
This was a fun bug - it had different behaviour for me - the top menu bar got drawn in the wrong place. The cause turned out to be a duplicated call to cairo_save(), with no cairo_restoer(). This messed up drawing of many widgets > >2) Background color doesn't get applied to the image browser during startup This just needed entangle_camera_manager_update_background_highlight to be called from do_entangle_camera_manager_set_app > >3) The background color doesn't get applied in full screen mode (F5) This just needed a entangle_image_popup_set_background which passed through to entangle_image_display_set_background. Similarly the image popup tearoffs needed bg setting. > A rebased patch, but still suffers from the 3 issues above. Thanks, I have updated it for the issues I mentioned above and pushed it to git. Oh, also turned some 'char *' into 'const char *' and added some missing 'g_free' calls on the colour strings. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Entangle-devel mailing list Entangle-devel@gna.org https://mail.gna.org/listinfo/entangle-devel
