On 04/02/2014 05:21 PM, Daniel P. Berrange wrote:
1) Images appear and disappear from the image browser when clicking around
This was a fun bug - it had different behaviour for me - the top menu
bar got drawn in the wrong place. The cause turned out to be a duplicated
call to cairo_save(), with no cairo_restoer(). This messed up drawing of
many widgets
2) Background color doesn't get applied to the image browser during startup
This just needed entangle_camera_manager_update_background_highlight
to be called from do_entangle_camera_manager_set_app
3) The background color doesn't get applied in full screen mode (F5)
This just needed a entangle_image_popup_set_background which passed
through to entangle_image_display_set_background.
Similarly the image popup tearoffs needed bg setting.
A rebased patch, but still suffers from the 3 issues above.
Thanks, I have updated it for the issues I mentioned above and pushed it
to git. Oh, also turned some 'char *' into 'const char *' and added some
missing 'g_free' calls on the colour strings.
Thanks a lot !!
I'm getting
(entangle:17791): Gtk-CRITICAL **: gtk_box_reorder_child: assertion
`GTK_IS_WIDGET (child)' failed
(entangle:17791): entangle-CRITICAL **:
entangle_application_get_preferences: assertion
`ENTANGLE_IS_APPLICATION(app)' failed
(entangle:17791): entangle-CRITICAL **:
entangle_preferences_img_set_background: assertion
`ENTANGLE_IS_PREFERENCES(prefs)' failed
when changing the colors, but maybe that is due to some cache... I'll
investigate.
Hope that the presentation went well, and have a great week !
Best regards,
Jesper
_______________________________________________
Entangle-devel mailing list
Entangle-devel@gna.org
https://mail.gna.org/listinfo/entangle-devel
